Review Request: fixes KWOdfWriter to write tracked changes before declarations (ODF 1.2 spec wants that)

Commit Hook null at kde.org
Fri Jul 13 10:44:54 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105545/#review15776
-----------------------------------------------------------


This review has been submitted with commit 51db1de934752bdd3d4f4236097e146a06835de2 by Friedrich W. H. Kossebau to branch calligra/2.5.

- Commit Hook


On July 13, 2012, 7:24 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105545/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 7:24 a.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> calligra/tools/scripts/validateODF.py complains about <text:tracked-changes> appearing after <text:user-field-decls> for OpenDocument-v1.1.odt. Because the schema of ODF 1.2 wants "office-text-content-prelude" to conform to
> 	<define name="office-text-content-prelude">
> 		<ref name="office-forms"/>
> 		<ref name="text-tracked-changes"/>
> 		<ref name="text-decls"/>
> 		<ref name="table-decls"/>
> 	</define>
> 
> Attached patch fixes KWOdfWriter to first write <text:tracked-changes>, only then the (user defined variable) declarations.
> 
> Okay to backport to 2.5?
> 
> 
> Diffs
> -----
> 
>   words/part/KWOdfWriter.cpp b061b96 
> 
> Diff: http://git.reviewboard.kde.org/r/105545/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120713/92478c64/attachment.htm>


More information about the calligra-devel mailing list