Review Request: replace deprecated KLocale::fragDigits with KLocale::monetaryDecimalNumbers in Calligra Sheets

[Friedrich W. H. Kossebau]

> On July 12, 2012, 10:15 p.m., C. Boemann wrote:
> > I could have sworn I saw a ship-it by Dag for this, or was that a similar request for Plan?
> > 
> >

Yes, I splitted between Sheets and Plan, hoping to split the review effort needed.
But currently most of the reviews seem to end up with you anyway :)

Many thanks for all the reviewing, really great to see my requests not catching any dust (unless quite tricky or big, like the koIcon one)!

I feel bad not being responsible for anything myself, so I do not have to do reviewing myself :) But my interest currently simply jumps around between all places in Calligra (well, to the issues I see). 


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105501/#review15752
-----------------------------------------------------------


On July 10, 2012, 6:18 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105501/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 6:18 a.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> -------
> 
> In kdelibs 4.4 KLocale::fragDigits was split into KLocale::monetaryDecimalNumbers and KLocale::decimalNumbers.
> 
> While the deprecated KLocale::fragDigits at least in 4.8 maps to KLocale::monetaryDecimalNumbers (though not documented in the API, just implementation), for me it still feels better to use the correct property directly if compiled against 4.4 and later. And in OpenCalcExport::exportDefaultCellStyle() it should be rather KLocale::decimalNumbers, not KLocale::monetaryDecimalNumbers, from what I understand.
> Also cleans the build output from the "Deprecated!" warnings :)
> 
> Patch also fixes Localization::defaultSystemConfig() still using "tables" and not "sheets" as id.
> 
> 
> Diffs
> -----
> 
>   filters/sheets/opencalc/opencalcexport.cc 383d328 
>   sheets/Localization.cpp 6989f4e 
>   sheets/ui/CellToolBase.cpp 89b79f9 
>   sheets/ui/CellToolBase_p.cpp bbfe480 
> 
> Diff: http://git.reviewboard.kde.org/r/105501/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120712/9c1e98ce/attachment.htm>