Review Request: fix/restore thumbnailing for Words

[Friedrich W. H. Kossebau]

Am Sonntag, 1. Juli 2012, 07:58:24 schrieb C. Boemann:
> > On July 1, 2012, 4:42 a.m., C. Boemann wrote:
> > > No idea if there is a better solution either, but if it works then fine
> > > with me.
> > > 
> > > Little nag why an item is used. What happens if it's widget based, pr am
> > > i just not understanding the issues here.
> > > 
> > > Anyway no objection for me if it works. ok to backport too (I trust you
> > > have tested well)> 
> > Friedrich W. H. Kossebau wrote:
> >     Seemed to me like the only way to get a shapemanager. But after your
> >     nagging I researched a little more and now found what that canvasitem
> >     is. So I will change the patch to first look if there is any view to
> >     take the shapemanager from, and only then create the item.
> >     
> >     And if you can nag Thorsten about
> >     https://git.reviewboard.kde.org/r/105390 to give it a final "Ship
> >     it!" (hopefully) I could improve this patch to reuse the
> >     KoPAUtil::setSizeAndZoom(...) I introduced there :)> 
> > C. Boemann wrote:
> >     Well sure I can nag Thorsten, but you can't use KoPAUtil in Words ..
> >     different framework> 
> > Friedrich W. H. Kossebau wrote:
> >     Oh, right. Was confused because KoPAUtil is also used in
> >     CSThumbProviderWords... Perhaps those utils could be moved up to
> >     KoDocument area...
> >     
> >     Hm, is using the shapemanager of a view from views() a safe thing to
> >     do? Could that view and its canvas and the shapemanager be destroyed
> >     while KWDocument::generatePreview(...) is called? E.g. will be called
> >     during KoDocument::saveNativeFormatODF(...). And someone before me
> >     wrote that>     
> >         foreach(KoShape* shape, shapeManager->shapes()) {
> >         
> >             shape->waitUntilReady(zoomHandler, false);
> >         
> >         }
> >     
> >     in KWPage::thumbnail(...), so that can take a while. Hm. That one
> >     single canvasitem seems a more safe thing to do, or? At least it
> >     worked for me (did not try Calligra Active though). Okay, will commit
> >     now as I have no better idea. And if someone then can tell Calligra
> >     Active has no issues as well, I will backport.
> Ok :)

So, any issues seen by anyone? Or alright to backport to 2.5 now (before we 
forget)?

Cheers
Friedrich