Review Request: make parsing of fo:clip more strict, but also backward compatible

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105528/
-----------------------------------------------------------

(Updated July 12, 2012, 7:17 p.m.)


Review request for Calligra, Inge Wallin and C. Boemann.


Changes
-------

fixed patch to allow negative values


Description (updated)
-------

As can be seen e.g. in odf/odt/OpenDocument-v1.1.odt from the calligratests, some OOo versions did not use commas as separators for the offset values in the value "rect(...)" for the attribute "fo:clip". So the parsing fails, for the given document e.g. with
--- 8< ---
KoUnit::parseValue: KoUnit::parseValue: Unit  "cm0cm0cm0cm"  is not supported, please report.
--- 8< ---

And while I created the attached patch with a workaround I changed the code to also:
    * detect "auto" values in rect(...)
    * check number of values in rect(...)

Okay to backport to 2.5?


Diffs (updated)
-----

  libs/flake/KoOdfWorkaround.h 18b801f 
  libs/flake/KoOdfWorkaround.cpp 9b8fce9 
  plugins/pictureshape/PictureShape.h 3937573 
  plugins/pictureshape/PictureShape.cpp 40c609b 

Diff: http://git.reviewboard.kde.org/r/105528/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120712/5457d315/attachment.htm>