Review Request: Cursor width must be multiple of 16 on Windows

[ivan miraglia]

Il 09/07/2012 11:06, Boudewijn Rempt ha scritto:
> On Monday 09 July 2012 Jul, Ivan Miraglia wrote:
>>
>>> On July 7, 2012, 2:07 p.m., Boudewijn Rempt wrote:
>>>> Awesome, many thanks!
>>
>> Hello Boudewijn,
>>
>> this is my first patch submission here in Calligra, so, I think that I need some other guidelines.
>>
>> What I have to do now? Do you expect that I push my patch into a personal public git repository? or do I push it into Calligra master directly? do I need write access for doing this? or what else?
>
>
> Yes, something like this you can push into master directly. I'll then push it into the 2.5 branch. If you prefer, I can do that for you, too.

I requested a contributor account through the "Developer Application' 
page. For what I understood, it is essential for pushing into Calligra 
master. I am not sure that I will get it. So, I prefer that you push the 
patch in the meanwhile.

Thank you for your support.

>
>>
>> I'm on travel currently, so, I apologize if I do not reply immediately.
>
> No problem!
>
>
>>
>> Thank you in advance for your help.
>>
>> Ivan Miraglia
>>
>>
>> - Ivan
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/105472/#review15512
>> -----------------------------------------------------------
>>
>>
>> On July 7, 2012, 1:47 p.m., Ivan Miraglia wrote:
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> http://git.reviewboard.kde.org/r/105472/
>>> -----------------------------------------------------------
>>>
>>> (Updated July 7, 2012, 1:47 p.m.)
>>>
>>>
>>> Review request for Calligra.
>>>
>>>
>>> Description
>>> -------
>>>
>>> Cursor width must be multiple of 16 on Windows.
>>> Some icons that are loaded into cursor by KisCursor::load have different width.
>>> For example, select the Transform Tool and try to rotate the selection. "rotate_cursor.xpm" is loaded into cursor.
>>>
>>>
>>> Diffs
>>> -----
>>>
>>>    krita/ui/kis_cursor.cc 02ec083
>>>
>>> Diff: http://git.reviewboard.kde.org/r/105472/diff/
>>>
>>>
>>> Testing
>>> -------
>>>
>>> Tested on Windows 7 home 64 bit. Windows XP Pro 32 bit.
>>>
>>>
>>> Thanks,
>>>
>>> Ivan Miraglia
>>>
>>>
>>
>>
>
>