Review Request: replace deprecated KLocale::fragDigits with KLocale::monetaryDecimalNumbers in Calligra Plan

Dag Andersen danders at get2net.dk
Tue Jul 10 10:50:20 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105500/#review15600
-----------------------------------------------------------

Ship it!


Ship It!

- Dag Andersen


On July 10, 2012, 5:52 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105500/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 5:52 a.m.)
> 
> 
> Review request for Calligra and Dag Andersen.
> 
> 
> Description
> -------
> 
> In kdelibs 4.4 KLocale::fragDigits was split into KLocale::monetaryDecimalNumbers and KLocale::decimalNumbers.
> 
> While the deprecated KLocale::fragDigits at least in 4.8 maps to KLocale::monetaryDecimalNumbers (though not documented in the API, just implementation), for me it still feels better to use the correct property directly if compiled against 4.4 and later.
> Also cleans the build output from the "Deprecated!" warnings :)
> 
> 
> Diffs
> -----
> 
>   plan/libs/kernel/kptcommand.cpp c55db49 
>   plan/libs/kernel/kptproject.cpp f095e70 
>   plan/libs/ui/locale/localemon.cpp 1584e63 
> 
> Diff: http://git.reviewboard.kde.org/r/105500/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120710/71fa85e8/attachment.htm>


More information about the calligra-devel mailing list