Review Request: replace deprecated KLocale::fragDigits with KLocale::monetaryDecimalNumbers in Calligra Sheets
Friedrich W. H. Kossebau
kossebau at kde.org
Tue Jul 10 07:18:03 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105501/
-----------------------------------------------------------
Review request for Calligra and Marijn Kruisselbrink.
Description
-------
In kdelibs 4.4 KLocale::fragDigits was split into KLocale::monetaryDecimalNumbers and KLocale::decimalNumbers.
While the deprecated KLocale::fragDigits at least in 4.8 maps to KLocale::monetaryDecimalNumbers (though not documented in the API, just implementation), for me it still feels better to use the correct property directly if compiled against 4.4 and later. And in OpenCalcExport::exportDefaultCellStyle() it should be rather KLocale::decimalNumbers, not KLocale::monetaryDecimalNumbers, from what I understand.
Also cleans the build output from the "Deprecated!" warnings :)
Patch also fixes Localization::defaultSystemConfig() still using "tables" and not "sheets" as id.
Diffs
-----
filters/sheets/opencalc/opencalcexport.cc 383d328
sheets/Localization.cpp 6989f4e
sheets/ui/CellToolBase.cpp 89b79f9
sheets/ui/CellToolBase_p.cpp bbfe480
Diff: http://git.reviewboard.kde.org/r/105501/diff/
Testing
-------
Thanks,
Friedrich W. H. Kossebau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120710/14487b73/attachment.htm>
More information about the calligra-devel
mailing list