Review Request: [calligratests] fixes bad strings "Formula.hidden" and "protected Formula.hidden" for style:cell-protect in Sheets

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105471/#review15508
-----------------------------------------------------------


This review has been submitted with commit 3696eccc1cdcf9175970eb78f1267706f46050d3 by Friedrich W. H. Kossebau to branch calligra/2.5.

- Commit Hook


On July 7, 2012, 11:56 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105471/
> -----------------------------------------------------------
> 
> (Updated July 7, 2012, 11:56 a.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> -------
> 
> Some mass rename a few years ago (d1fa9526) seems to have left a dirty trace in sheets/Style.cpp, it turned the strings "formula-hidden"/"protected formula-hidden" into "Formula.hidden"/"protected Formula.hidden". Which is wrong of course. And makes e.g. odf/ods/Financial_Report.ods from the calligratests fail.
> 
> Attached patch fixes the strings, and also adds a workaround for loading of files with the broken strings.
> 
> Okay to backport to 2.5?
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoOdfWorkaround.h 8672f22 
>   libs/flake/KoOdfWorkaround.cpp 8d3d523 
>   sheets/Style.cpp 7e32a29 
> 
> Diff: http://git.reviewboard.kde.org/r/105471/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120707/a431a18c/attachment.htm>