Review Request: [calligratests] fixes bad strings "Formula.hidden" and "protected Formula.hidden" for style:cell-protect in Sheets

Friedrich W. H. Kossebau kossebau at kde.org
Sat Jul 7 12:56:12 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105471/
-----------------------------------------------------------

Review request for Calligra and Marijn Kruisselbrink.


Description
-------

Some mass rename a few years ago (d1fa9526) seems to have left a dirty trace in sheets/Style.cpp, it turned the strings "formula-hidden"/"protected formula-hidden" into "Formula.hidden"/"protected Formula.hidden". Which is wrong of course. And makes e.g. odf/ods/Financial_Report.ods from the calligratests fail.

Attached patch fixes the strings, and also adds a workaround for loading of files with the broken strings.

Okay to backport to 2.5?


Diffs
-----

  libs/flake/KoOdfWorkaround.h 8672f22 
  libs/flake/KoOdfWorkaround.cpp 8d3d523 
  sheets/Style.cpp 7e32a29 

Diff: http://git.reviewboard.kde.org/r/105471/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120707/6c44720d/attachment.htm>


More information about the calligra-devel mailing list