Review Request: KoPageFormat: add getter for list of non-localized page sizes

Jarosław Staniek staniek at kde.org
Fri Jul 6 21:52:25 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105434/#review15477
-----------------------------------------------------------

Ship it!


OK (please fix at line 168)


libs/odf/KoPageFormat.cpp
<http://git.reviewboard.kde.org/r/105434/#comment12096>

    --> 
    QStringList KoPageFormat::allShortNames() const


- Jarosław Staniek


On July 4, 2012, 10:41 a.m., Dag Andersen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105434/
> -----------------------------------------------------------
> 
> (Updated July 4, 2012, 10:41 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This is needed by KoReportDesigner to be able to display localized list in ui and to write non-localized value to xml.
> 
> 
> Diffs
> -----
> 
>   libs/odf/KoPageFormat.h bf1c4f4 
>   libs/odf/KoPageFormat.cpp 41ad047 
> 
> Diff: http://git.reviewboard.kde.org/r/105434/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dag Andersen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120706/52b4b592/attachment.htm>


More information about the calligra-devel mailing list