Review Request: [calligratests] fix table cell style code wrongly saving/loading draw:opacity with ODF

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105444/
-----------------------------------------------------------

Review request for Calligra and C. Boemann.


Description
-------

The calligratests files
interoperability/wordprocessing/oowriter/oow_template_blank_musical_sheet.odt and
interoperability/wordprocessing/oowriter/oow_template_note_tracker.odt 	 
fail with
--- 8< ---
INVALIDCONTENTXML: (unknown file):56: error: element "style:graphic-properties" not allowed here; expected the element end-tag or element "style:map", "style:paragraph-properties" or "style:text-properties"
(unknown file):60: error: element "style:graphic-properties" not allowed here; expected the element end-tag or element "style:map", "style:paragraph-properties" or "style:text-properties"
--- 8< ---

Reason is that style:graphic-properties are not to be used for table cell styles, only style:table-cell-properties. Which means no support for opacity with table cells at all on the saving/loading level. Should it be done in the Calligra namespace at least? But I also was not able to set any opacity with the Calligra UI, so perhaps there is no need for that yet.

Attached patch fixes both tests, by removing the code trying to load/save draw:opacity.

Okay to backport also to 2.5?


Diffs
-----

  libs/kotext/styles/KoTableCellStyle.cpp 753d33c 

Diff: http://git.reviewboard.kde.org/r/105444/diff/


Testing
-------

tools/scripts/validateODF.py reports no more errors on oow_template_note_tracker.odt and oow_template_blank_musical_sheet.odt


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120704/7b850032/attachment.htm>