Review Request: make Calligra thumbnailer functional again

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105373/
-----------------------------------------------------------

(Updated July 4, 2012, 1:08 p.m.)


Review request for Calligra and Boudewijn Rempt.


Changes
-------

Updated patch with latest state and also included the fix for Krita files which currently get icons blended.


Description (updated)
-------

Currently the Calligra thumbnailer is slightly broken:
* it claims to support a fixed set of mimetypes, even if not all of Calligra is built.
* it reports the flags like BlendIcon based on the last document a preview was done for
* it does not offer to create mimetypes for formats supported by import filters
* it might not really wait for the rendering of the loaded document

Attached patch fixes that by:
* duplicate into two plugins:
  calligraimagethumbnail for preview without blending the icon (for all image formats),
  calligrathumbnail for preview with blending the icon (for all other)
* wait for result of thumbnail rendering
* extends the range of supported mimetypes with the MS formats and some other otherwise not done.
* install separate thumbnail descriptions per import filter and only if
  the import filter is installed
* put a white background behind extracted mimetypes (as OO/LI creates transparent backgrounds which look bad then)

But this uncovers some problems:
First is that at least for xfig images the imagethumbnailer of kde-runtime hides the Calligra-based one. A patch to fix this is commited to kde-runtime for 4.8.5 and 4.9.0.
Second is that the result of some KoDocument subclasses is not really perfect, Words and Flow/Stage have seen fixes, but at least Sheets still needs one. Separate issue, separate patch, as this also is valid for the thumbnails added on storing ODS.

And some filters could possibly use a preview image from the original format? But that is also outside the scope of this patch.

Okay to backport to 2.5? Would ask for string freeze exception for all the separate mimetypes.


Diffs (updated)
-----

  filters/flow/visio/import/CMakeLists.txt 0f42264 
  filters/flow/visio/import/flow_vsdx_thumbnail.desktop PRE-CREATION 
  filters/karbon/karbon1.x/CMakeLists.txt 127a2aa 
  filters/karbon/karbon1.x/karbon_karbon1x_thumbnail.desktop PRE-CREATION 
  filters/karbon/xfig/CMakeLists.txt b3b21a9 
  filters/karbon/xfig/karbon_xfig_thumbnail.desktop PRE-CREATION 
  filters/sheets/excel/import/CMakeLists.txt 7ae3cbb 
  filters/sheets/excel/import/sheets_excel_thumbnail.desktop PRE-CREATION 
  filters/sheets/xlsx/CMakeLists.txt a637afa 
  filters/sheets/xlsx/sheets_xlsx_thumbnail.desktop PRE-CREATION 
  filters/stage/kpr2odf/CMakeLists.txt 96b5650 
  filters/stage/kpr2odf/stage_kpr_thumbnail.desktop PRE-CREATION 
  filters/stage/powerpoint/CMakeLists.txt 8e5478c 
  filters/stage/powerpoint/stage_powerpoint_thumbnail.desktop PRE-CREATION 
  filters/stage/pptx/CMakeLists.txt 3332270 
  filters/stage/pptx/stage_pptx_thumbnail.desktop PRE-CREATION 
  filters/words/docx/CMakeLists.txt 30111e4 
  filters/words/docx/words_docx_thumbnail.desktop PRE-CREATION 
  filters/words/msword-odf/CMakeLists.txt 2f79f7b 
  filters/words/msword-odf/words_msword_thumbnail.desktop PRE-CREATION 
  filters/words/rtf/import/CMakeLists.txt 4a6fe10 
  filters/words/rtf/import/words_rtf_thumbnail.desktop PRE-CREATION 
  filters/words/wordperfect/import/CMakeLists.txt 5efb0b0 
  filters/words/wordperfect/import/words_wpd_thumbnail.desktop PRE-CREATION 
  filters/words/works/import/CMakeLists.txt 83f5254 
  filters/words/works/import/words_wps_thumbnail.desktop PRE-CREATION 
  krita/plugins/formats/ora/CMakeLists.txt 666de52 
  krita/plugins/formats/ora/krita_ora_thumbnail.desktop PRE-CREATION 
  tools/thumbnail/CMakeLists.txt f7aac3f 
  tools/thumbnail/calligracreator.h dfe50d2 
  tools/thumbnail/calligracreator.cpp 804b0db 
  tools/thumbnail/calligraodgthumbnail.desktop PRE-CREATION 
  tools/thumbnail/calligrathumbnail.desktop 2c2272c 
  tools/thumbnail/kritathumbnail.desktop PRE-CREATION 
  tools/thumbnail/otherofficethumbnail.desktop e62eba1 
  tools/thumbnail/sheetsodsthumbnail.desktop PRE-CREATION 
  tools/thumbnail/stageodpthumbnail.desktop PRE-CREATION 
  tools/thumbnail/wordsodtthumbnail.desktop PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105373/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120704/5ae3465e/attachment.htm>