Review Request: implement marker settings in charts

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105252/#review15335
-----------------------------------------------------------

Ship it!


Very nice, all my issues were fixed.  I found some very small things remaining but just fix them and then you can commit.  No reason to run another lap through the reviewboard treadwheel.


plugins/chartshape/DataSet.h
<http://git.reviewboard.kde.org/r/105252/#comment11954>

    Is it really necessary to include a KDChart include file in the .h file for DataSet?  Should be possible to have in the .cpp, right?



plugins/chartshape/DataSet.h
<http://git.reviewboard.kde.org/r/105252/#comment11955>

    Static methods shouldn't be exposed in the .h file.


- Inge Wallin


On July 3, 2012, 10:52 a.m., Brijesh Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105252/
> -----------------------------------------------------------
> 
> (Updated July 3, 2012, 10:52 a.m.)
> 
> 
> Review request for Calligra, Inge Wallin and C. Boemann.
> 
> 
> Description
> -------
> 
> This patch adds UI for markers and implements setting of marker for datasets.
> 
> 
> Diffs
> -----
> 
>   plugins/chartshape/ChartConfigWidget.h aa89815 
>   plugins/chartshape/ChartConfigWidget.cpp 4f4a705 
>   plugins/chartshape/ChartConfigWidget.ui b142635 
>   plugins/chartshape/ChartTool.h 779b7ef 
>   plugins/chartshape/ChartTool.cpp bab225a 
>   plugins/chartshape/DataSet.h 023c060 
>   plugins/chartshape/DataSet.cpp 2821254 
>   plugins/chartshape/Legend.cpp e74a77f 
>   plugins/chartshape/kchart_global.h 7b55111 
>   plugins/chartshape/kdchart/src/KDChartAbstractDiagram.h a410cb8 
>   plugins/chartshape/kdchartpatches/README 9d3f184 
>   plugins/chartshape/kdchartpatches/paint-marker-static.diff PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105252/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brijesh Patel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120703/297ee9a3/attachment.htm>