Review Request: Port tables plugin to QUndo/kundo2

[Adam Pigg]

> On July 2, 2012, 8:04 p.m., Jarosław Staniek wrote:
> > kexi/plugins/tables/kexitabledesignerview.cpp, line 1130
> > <http://git.reviewboard.kde.org/r/105366/diff/4/?file=71093#file71093line1130>
> >
> >     why is this line removed?

Because it is not needed.  In the lines above, the setPrimaryKeyCommand is created with topLevelCommand as a parent.


> On July 2, 2012, 8:04 p.m., Jarosław Staniek wrote:
> > kexi/plugins/tables/kexitabledesignerview.cpp, line 1157
> > <http://git.reviewboard.kde.org/r/105366/diff/4/?file=71093#file71093line1157>
> >
> >     why is this line removed?

Because it is not needed.  In the lines above, the setPrimaryKeyCommand is created with topLevelCommand as a parent.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105366/#review15318
-----------------------------------------------------------


On July 2, 2012, 7:42 p.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105366/
> -----------------------------------------------------------
> 
> (Updated July 2, 2012, 7:42 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Ported tables plugin to kundo2.
> 
> The purpose of the review is for early feedback to ensure work is in the right direction.  All crashes/problems will be fixed.
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/tables/kexitabledesignerview_p.cpp 49af8fcfc7be103a841cf7a5ffd8abbd75e694bc 
>   kexi/plugins/tables/kexitabledesignerview_p.h 8f2744fc52d5902f89894bef107109ff09909236 
>   kexi/plugins/tables/kexitabledesignerview.h 04710ffda0808563ebbfd73ecbbcddee72224267 
>   kexi/plugins/tables/kexitabledesignerview.cpp 8ec956d73ca7874558ac5e3a1d5bd68a18c3c815 
>   kexi/plugins/tables/kexitabledesignercommands.cpp 89bd10f939f17083cac0e9fa83c6c628fb555009 
>   kexi/plugins/tables/CMakeLists.txt a29b2b944d071149f92d46b8ecc09885d4604035 
>   kexi/plugins/tables/kexilookupcolumnpage.cpp 4c459c41162400c3427cd04ef11a40f7b553f9a9 
>   kexi/plugins/tables/kexitabledesignercommands.h e906388055f508f0316b4fee3fdccb2e4379b8d8 
> 
> Diff: http://git.reviewboard.kde.org/r/105366/diff/
> 
> 
> Testing
> -------
> 
> Opened an existing table and changed some property names
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120702/27833f43/attachment.htm>