Review Request: Add unit test of report page options

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105411/#review15313
-----------------------------------------------------------

Ship it!


Brilliant! Good job, Dag!


libs/koreport/tests/KoReportTest.cpp
<http://git.reviewboard.kde.org/r/105411/#comment11929>

    Alternative, simpler notation:
    
    QString s =
    "<report:content xmlns:report=\"http://kexi-project.org/report/2.0\""
    " xmlns:fo=\"urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0\""
    ....



libs/koreport/tests/KoReportTest.cpp
<http://git.reviewboard.kde.org/r/105411/#comment11930>

    'needs detail section, or else designer crash' - if that's true maybe we could fix the crash somehow (e.g. refuse to load)?


- Jarosław Staniek


On July 2, 2012, 2:14 p.m., Dag Andersen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105411/
> -----------------------------------------------------------
> 
> (Updated July 2, 2012, 2:14 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> Adds unit test of page options.
> XMl is loaded into designer and checked. Xml is then generated and loaded into KoReportPreRenderer and checked again.
> 
> 
> Diffs
> -----
> 
>   libs/koreport/tests/KoReportTest.cpp PRE-CREATION 
>   libs/koreport/renderer/KoReportPreRenderer.h 68e6136 
>   libs/koreport/renderer/KoReportPreRenderer.cpp fb057b0 
>   libs/koreport/tests/CMakeLists.txt PRE-CREATION 
>   libs/koreport/tests/KoReportTest.h PRE-CREATION 
>   libs/koreport/CMakeLists.txt d0737c9 
>   libs/koreport/common/krreportdata.h 6280d6e 
>   libs/koreport/common/krreportdata.cpp 4adf547 
>   libs/koreport/koreport_export.h 91031ff 
> 
> Diff: http://git.reviewboard.kde.org/r/105411/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dag Andersen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120702/dd1a4ce0/attachment.htm>