Review Request: fix & improve template generation code

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105406/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

Another patch done on my quest to make thumbnails and previews working:

* fix loading of proper high-size icon (Desktop is usually not 128 pixels)
* fix preview generation to create 128x128 instead of 60x60 
* ensure saving of quadratic icons if preview or custom image is used
* move code duplication around call of KoTemplateCreateDia::createTemplate(...)
  into that method (would like an answer on the TODO added there)
* remove redundant label "Preview:" from dialog
* make Select... button in dialog to align at right side, instead of sticking to the string "Custom"

Ideally also gets backport to calligra/2.5...


Diffs
-----

  krita/ui/kis_view2.cpp 97a7b54 
  libs/main/KoTemplate.cpp e74aaa4 
  libs/main/KoTemplateCreateDia.h 4c4e478 
  libs/main/KoTemplateCreateDia.cpp c6b79f8 
  plan/kptview.cpp ed28be3 
  sheets/part/View.cpp c6d6b3c 
  words/part/KWView.cpp 88a3de4 

Diff: http://git.reviewboard.kde.org/r/105406/diff/


Testing
-------

Oh yes... Created new templates via the dialog in Words, Krita & Sheets, with and without custom pictures of all kind.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120701/0036f5fe/attachment.htm>