Review Request: fix/restore thumbnailing for Words

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105385/#review15270
-----------------------------------------------------------

Ship it!


No idea if there is a better solution either, but if it works then fine with me.

Little nag why an item is used. What happens if it's widget based, pr am i just not understanding the issues here.

Anyway no objection for me if it works. ok to backport too (I trust you have tested well)

- C. Boemann


On June 29, 2012, 4:42 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105385/
> -----------------------------------------------------------
> 
> (Updated June 29, 2012, 4:42 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Currently the thumbnailing for documents saved with Words is broken. Attached patch makes it at least working again, no idea if there are better solutions to get the result, I relied on the existing code in KWPage::thumbnail(...)
> 
> Okay to also backport to 2.5?
> 
> 
> Diffs
> -----
> 
>   words/part/KWDocument.h a8d8ae4 
>   words/part/KWDocument.cpp d5c4c2e 
>   words/part/KWPage.cpp 8ce9554 
> 
> Diff: http://git.reviewboard.kde.org/r/105385/diff/
> 
> 
> Testing
> -------
> 
> Created a few new files and looked at the thumbnails stored in the saved odf.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120701/a1cff775/attachment.htm>