Review Request: Improved html-odf Words export filter

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103778/#review10043
-----------------------------------------------------------


more formatting issues

i'll checkout your branch and give it a spin


filters/words/html-odf/ManifestParser.h
<http://git.reviewboard.kde.org/r/103778/#comment8256>

    still space



filters/words/html-odf/ManifestParser.h
<http://git.reviewboard.kde.org/r/103778/#comment8257>

    still spaces



filters/words/html-odf/ManifestParser.cpp
<http://git.reviewboard.kde.org/r/103778/#comment8258>

    spaces



filters/words/html-odf/ManifestParser.cpp
<http://git.reviewboard.kde.org/r/103778/#comment8259>

    spaces



filters/words/html-odf/ManifestParser.cpp
<http://git.reviewboard.kde.org/r/103778/#comment8260>

    please space between type and &
    
    will not comment on other cases of this



filters/words/html-odf/ManifestParser.cpp
<http://git.reviewboard.kde.org/r/103778/#comment8261>

    should be: if (int
    
    same for all keyword kind of statement.
    
    wheras method calls should be: func(arg
    
    will not comment on this below



filters/words/html-odf/ManifestParser.cpp
<http://git.reviewboard.kde.org/r/103778/#comment8262>

    I've always learnt it's bad to return references, even when const
    
    and method should probably be const too



filters/words/html-odf/conversion/converter.xsl
<http://git.reviewboard.kde.org/r/103778/#comment8267>

    space



filters/words/html-odf/conversion/converter.xsl
<http://git.reviewboard.kde.org/r/103778/#comment8268>

    spaces



filters/words/html-odf/conversion/converter.xsl
<http://git.reviewboard.kde.org/r/103778/#comment8269>

    spaces



filters/words/html-odf/conversion/converter.xsl
<http://git.reviewboard.kde.org/r/103778/#comment8270>

    spaces



filters/words/html-odf/conversion/converter.xsl
<http://git.reviewboard.kde.org/r/103778/#comment8271>

    spaces



filters/words/html-odf/conversion/converter.xsl
<http://git.reviewboard.kde.org/r/103778/#comment8272>

    spaces



filters/words/html-odf/conversion/converter.xsl
<http://git.reviewboard.kde.org/r/103778/#comment8273>

    space



filters/words/html-odf/conversion/converter.xsl
<http://git.reviewboard.kde.org/r/103778/#comment8274>

    space



filters/words/html-odf/conversion/converter.xsl
<http://git.reviewboard.kde.org/r/103778/#comment8275>

    space



filters/words/html-odf/conversion/converter.xsl
<http://git.reviewboard.kde.org/r/103778/#comment8276>

    space



filters/words/html-odf/htmlodfexport.cpp
<http://git.reviewboard.kde.org/r/103778/#comment8263>

    I know it's not your fault but wouldn't filenameWithoutExtension be a better name
    
    text is so nondescriptive and it should be camelCase anyway



filters/words/html-odf/htmlodfexport.cpp
<http://git.reviewboard.kde.org/r/103778/#comment8264>

    spaces



filters/words/html-odf/htmlodfexport.cpp
<http://git.reviewboard.kde.org/r/103778/#comment8265>

    space



filters/words/html-odf/htmlodfexport.cpp
<http://git.reviewboard.kde.org/r/103778/#comment8266>

    spaces


- C. Boemann


On Jan. 24, 2012, 12:31 p.m., Stuart Dickson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103778/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2012, 12:31 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Improvements to the html-odf export filter.
> 
> Added support for: exporting images, tables with merged cells.
> Modifications to KoFilter derived class to incorporate Conversion class' convert function and provide improved error checking.
> Changes to output styles to improve legibility.
> Disabled export filter dialog as it does not have an impact on output, but can be modified in future. 
> Removing QChar::ObjectReplacementMarkers from appearing in output.
> 
> The focus has been on the content and not on styles and there is still improvement in cleaning up the generated output.
> 
> 
> Diffs
> -----
> 
>   filters/words/html-odf/CMakeLists.txt d1bee3f 
>   filters/words/html-odf/ManifestParser.h PRE-CREATION 
>   filters/words/html-odf/ManifestParser.cpp PRE-CREATION 
>   filters/words/html-odf/conversion/converter.xsl 1f01ed6 
>   filters/words/html-odf/convert.h 8cbdd6c 
>   filters/words/html-odf/convert.cpp 226fbd5 
>   filters/words/html-odf/htmlodfexport.h bff8dec 
>   filters/words/html-odf/htmlodfexport.cpp 5f0606e 
> 
> Diff: http://git.reviewboard.kde.org/r/103778/diff/diff
> 
> 
> Testing
> -------
> 
> Testing against a couple of sample documents including paragraphs, titles, simple tables and ones with additional merged cells, inline and paragraph anchored images.
> 
> 
> Thanks,
> 
> Stuart Dickson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120124/2c2787c9/attachment.htm>