Review Request: undo,redo of style changes

C. Boemann cbr at boemann.dk
Tue Jan 24 09:52:48 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103779/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

    Implement undo of Style changes
    
    Two new methods are introduced: beginEdit() and endEdit() to mark
    when the editing happens. At endEdit() the collected changes
    are applied to any attached documents like before.
    
    The difference is that it now happens through ChangeStylesMacroCommand
    Which in turn uses ChangeStylesCommand
    
    The role of ChangeStylesMacroCommand is to act as a macro plus to
    make sure the styles within the stylemanager itself are updated.
    
    The role of ChangeStylesCommand is to update the qtextdocuments.


Diffs
-----

  libs/kotext/CMakeLists.txt 6507227 
  libs/kotext/KoTextDocument.cpp e551825 
  libs/kotext/commands/ChangeStylesCommand.h PRE-CREATION 
  libs/kotext/commands/ChangeStylesCommand.cpp PRE-CREATION 
  libs/kotext/commands/ChangeStylesMacroCommand.h PRE-CREATION 
  libs/kotext/commands/ChangeStylesMacroCommand.cpp PRE-CREATION 
  libs/kotext/opendocument/tests/TestChangeTracking.cpp 3aac170 
  libs/kotext/opendocument/tests/TestLoadStyle.cpp cafe7d9 
  libs/kotext/opendocument/tests/TestLoading.cpp d464480 
  libs/kotext/styles/ChangeFollower.h 5aa42b0 
  libs/kotext/styles/ChangeFollower.cpp 5b10a65 
  libs/kotext/styles/KoCharacterStyle.cpp 9783bc3 
  libs/kotext/styles/KoParagraphStyle.cpp b7a5159 
  libs/kotext/styles/KoStyleManager.h bf6076c 
  libs/kotext/styles/KoStyleManager.cpp c5f645b 
  libs/kotext/styles/tests/TestListStyle.cpp 47c1137 
  libs/kotext/tests/TestKoTextEditor.cpp 751c465 
  libs/textlayout/tests/TestBlockLayout.cpp bb2cc16 
  libs/textlayout/tests/TestDocumentLayout.cpp 277178f 
  libs/textlayout/tests/TestTableLayout.cpp 2bcf0a2 
  plugins/textshape/dialogs/StyleManager.cpp 2e57137 
  tables/Map.cpp cd77d3a 

Diff: http://git.reviewboard.kde.org/r/103779/diff/diff


Testing
-------


Thanks,

C. Boemann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120124/1b598c17/attachment.htm>


More information about the calligra-devel mailing list