Review Request: Replace the current half baked style selection widgets with a home brewed comboBox

[Thorsten Zachmann]

> On Jan. 12, 2012, 8:01 a.m., Thorsten Zachmann wrote:
> > plugins/textshape/TextTool.cpp, lines 1803-1810
> > <http://git.reviewboard.kde.org/r/103677/diff/1/?file=46464#file46464line1803>
> >
> >     How about intializing charStyle with style?
> 
> Pierre Stirnweiss wrote:
>     There is no KoCharacterStyle(KoCharacterStyle *otherStyle) constructor. So I don't think we can.

That is not what I meant. My idead was the following:

KoCharacterStyle *charStyle = style;
if (!charStyle) {
   charStyle = ....
}


> On Jan. 12, 2012, 8:01 a.m., Thorsten Zachmann wrote:
> > libs/textlayout/KoStyleThumbnailer.cpp, line 124
> > <http://git.reviewboard.kde.org/r/103677/diff/1/?file=46461#file46461line124>
> >
> >     The if is useless as it will always a pointer when clone is a pointer.
> 
> Pierre Stirnweiss wrote:
>     Actually this can't be done by clone. clone is initially a KoParagraphStyle. When accessing the properties of clone, we get the paragraph properties, not the character properties.
>     I agree that since a paragraphStyle is an inherited characterStyle, this test should never fail (until next re-factoring, in which case we would crash if we forget about that area of code, which we probably would)

The comment above does work. As it makes sure to call the correct method.

QTextFormat format;
clone->KoCharStyle::applyStyle(format);


> On Jan. 12, 2012, 8:01 a.m., Thorsten Zachmann wrote:
> > plugins/textshape/CMakeLists.txt, lines 38-39
> > <http://git.reviewboard.kde.org/r/103677/diff/1/?file=46462#file46462line38>
> >
> >     Would it make sense to move the to libs/widgets ?
> 
> Pierre Stirnweiss wrote:
>     If these get used somewhere else than TextShape, sure. For now, I have designed them with textShape only in mind. Should we move them, the API might want to be adjusted.

We can still do it later


> On Jan. 12, 2012, 8:01 a.m., Thorsten Zachmann wrote:
> > plugins/textshape/dialogs/StylesModel.cpp, line 69
> > <http://git.reviewboard.kde.org/r/103677/diff/1/?file=46478#file46478line69>
> >
> >     I think the As paragraph is not very descriptive of what it does. 
> >     
> >     How about "Style of Paragraph used"?
> >      
> >     Also I think we should translate this string.
> 
> Pierre Stirnweiss wrote:
>     Is it ok to burden the translators right now? a translator listening to this perhaps can answer?

I think it would help the application and make it more usefull. You can ask Cyrille about it to be sure. But I'm all for it


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103677/#review9762
-----------------------------------------------------------


On Jan. 15, 2012, 2:03 p.m., Pierre Stirnweiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103677/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2012, 2:03 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Merge request.
> Merge branch textshape_stylesWidget_pierreSt into master.
> The branch provides a replacement for the style selection widgets. The new provided widgets are a subclass of QComboBox.
> They provide a style preview both in the main area and in the dropdown menu.
> The dropdown menu provides a "show style manager" button, which call the whole style management dialog.
> The dropdown also provides a "delete style" button, although this is for the moment disabled/commented out, because deleting a style is not currently really supported.
> The combo also allows to create a style based on the current text format if it does not correspond to the original style (ie. the user changed a property).
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoTextEditor.h 94bf433 
>   libs/kotext/KoTextEditor.cpp 9f242e6 
>   libs/kotext/styles/KoCharacterStyle.h 898ba43 
>   libs/kotext/styles/KoCharacterStyle.cpp f9e0741 
>   libs/kotext/styles/KoParagraphStyle.h 12ab672 
>   libs/textlayout/CMakeLists.txt af6d64a 
>   libs/textlayout/FrameIterator.h c73d580 
>   libs/textlayout/KoStyleThumbnailer.h 8645089 
>   libs/textlayout/KoStyleThumbnailer.cpp 3529bbb 
>   merge_textshape.diff PRE-CREATION 
>   plugins/textshape/CMakeLists.txt fad7c04 
>   plugins/textshape/TextTool.h f8de126 
>   plugins/textshape/TextTool.cpp f6822bd 
>   plugins/textshape/dialogs/SimpleCharacterWidget.h ad944a5 
>   plugins/textshape/dialogs/SimpleCharacterWidget.cpp 6b2bb66 
>   plugins/textshape/dialogs/SimpleCharacterWidget.ui e4f6d3b 
>   plugins/textshape/dialogs/SimpleParagraphWidget.h bc167b4 
>   plugins/textshape/dialogs/SimpleParagraphWidget.cpp cbfacfe 
>   plugins/textshape/dialogs/SimpleParagraphWidget.ui b2e9adf 
>   plugins/textshape/dialogs/StylesCombo.h PRE-CREATION 
>   plugins/textshape/dialogs/StylesCombo.cpp PRE-CREATION 
>   plugins/textshape/dialogs/StylesComboPreview.h PRE-CREATION 
>   plugins/textshape/dialogs/StylesComboPreview.cpp PRE-CREATION 
>   plugins/textshape/dialogs/StylesDelegate.h f5d216f 
>   plugins/textshape/dialogs/StylesDelegate.cpp d1021f5 
>   plugins/textshape/dialogs/StylesModel.h dbd17b4 
>   plugins/textshape/dialogs/StylesModel.cpp 94deb24 
>   plugins/textshape/dialogs/StylesWidget.cpp 4f31a01 
>   plugins/textshape/dialogs/TableOfContentsStyleModel.cpp 48ee7c3 
> 
> Diff: http://git.reviewboard.kde.org/r/103677/diff/diff
> 
> 
> Testing
> -------
> 
> The functionality exclusively linked to the comboBox seems to be working properly. Some defects have been identified (like no paragraph style is selected at startup), but these are actually outside the scope of this widget and affecting the current widget also.
> 
> 
> Thanks,
> 
> Pierre Stirnweiss
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120115/ac72ef9f/attachment.htm>