Review Request: Replace the current half baked style selection widgets with a home brewed comboBox

[C. Boemann]

On Saturday 14 January 2012 15:24:33 Pierre Stirnweiss wrote:
> > On Jan. 12, 2012, 8:01 a.m., Thorsten Zachmann wrote:
> > > libs/kotext/styles/KoCharacterStyle.cpp, lines 2130-2131
> > > <http://git.reviewboard.kde.org/r/103677/diff/1/?file=46456#file46456li
> > > ne2130>
> > > 
> > >     This change seems to be wrong as it will return stuff that should
> > >     not be returned here.
> 
> Well, these hard coded default are applied when the style is applied. And
> since this function does not return only what is defined in that
> particular style but also moves up the parenting chain, i think these
> properties should also be returned. If not, there is a discrepancy between
> what the styles apply on a format and what the style returns as a value:
> If I have:
> QTextCharFormat format;
> style->applyStyle(format);
> Then format.property(some hard coded property) returns a value, but
> style.value(that same property) is undefined. I don't find this
> discrepancy logical.
> 
> 
> - Pierre
> 
that is correct and needed to make inheritance work