Review Request: Implement tripleclicking

C. Boemann cbr at boemann.dk
Thu Jan 12 21:25:24 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103686/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

    Implement tripleclicking

    To do so I had to reroute doubleclicking into toolproxy mousepress
    
    However for applications there are no change, except tools can now
    reimplement mouseTripleClickEvent to be notified of a triple click
    
    4 or more clicks are interpreted as (repeated) tripleclick. That
    is until the doubleclicktimeout period has elapsed since the first
    click.
    
    The behaviour is smooth and as expected. I've also change texttool
    take advantage of it and actiually select the paragraph on third
    click and not as before where doubliclcking alternated between
    selecting word and line
    
    This patch also fixes a bug where doublclickig a word selects the
    space after (it's a matter of taste and windows always selects the
    space. but it seems most people like to only select the word.
    BUG: 291124


Diffs
-----

  libs/flake/KoToolBase.h 466319a 
  libs/flake/KoToolBase.cpp 940ab45 
  libs/flake/KoToolProxy.cpp edd3668 
  libs/flake/KoToolProxy_p.h 937ebd1 
  plugins/textshape/TextTool.h f8de126 
  plugins/textshape/TextTool.cpp f6822bd 

Diff: http://git.reviewboard.kde.org/r/103686/diff/diff


Testing
-------


Thanks,

C. Boemann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120112/16831bd4/attachment.htm>


More information about the calligra-devel mailing list