Review Request: tables documentation update for 2.4

Marijn Kruisselbrink mkruisselbrink at kde.org
Mon Jan 9 17:16:03 GMT 2012



> On Jan. 3, 2012, 10:59 a.m., Burkhard Lück wrote:
> > doc/tables/functions.docbook, lines 1-10
> > <http://git.reviewboard.kde.org/r/103614/diff/2/?file=45338#file45338line1>
> >
> >     I need some input here
> 
> Burkhard Lück wrote:
>     Is functions.docbook what Tables Maintainer(s) want?
>     
>     I don't want to through 1500 messages into the translation system without OK from Developers.

This is auto-generated from the .xml files, right? Shouldn't in that case all the translations already exist, since the actual xml files get their strings extracted? Not sure if it is possible to somehow link those two together though.


> On Jan. 3, 2012, 10:59 a.m., Burkhard Lück wrote:
> > doc/tables/importexport.docbook, lines 1-6
> > <http://git.reviewboard.kde.org/r/103614/diff/2/?file=45339#file45339line1>
> >
> >     Remove this docbook?
> >     
> >     Not much valid/uptodate infos here

I agree, doesn't seem to have much useful information.


> On Jan. 3, 2012, 10:59 a.m., Burkhard Lück wrote:
> > doc/tables/faq.docbook, lines 1-33
> > <http://git.reviewboard.kde.org/r/103614/diff/2/?file=45336#file45336line1>
> >
> >     Does it really make sense to keep this docbook?
> >     
> >     I'd like to remove it and move the info about template storage to the templates section in basics.docbook

Yeah, a faq with two questions, one of which indeed has the wrong answer is not the most useful thing. (for reference, number of columns is still correct, number of rows is 1,048,576 these days)


> On Jan. 3, 2012, 10:59 a.m., Burkhard Lück wrote:
> > doc/tables/configdialog.docbook, lines 306-308
> > <http://git.reviewboard.kde.org/r/103614/diff/2/?file=45335#file45335line306>
> >
> >     Empty here, hat should be on the plugins page?

Oops, seems I renamed the service-type in the servicetype .desktop file, but not in the actual plugins (not that there really are any plugins at the moment, but still something that should be fixed of course)


> On Jan. 3, 2012, 10:59 a.m., Burkhard Lück wrote:
> > doc/tables/advanced.docbook, lines 47-51
> > <http://git.reviewboard.kde.org/r/103614/diff/2/?file=45331#file45331line47>
> >
> >     Works here only with two cells with custom list entries, not with one custom list entry in one cell

Seems to have some bugs in the code indeed, it's supposed to work with one entry, but currently only for times and dates it will use a non-0 delta with only one cell selected.


- Marijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103614/#review9493
-----------------------------------------------------------


On Jan. 3, 2012, 10:42 a.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103614/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2012, 10:42 a.m.)
> 
> 
> Review request for Calligra, Marijn Kruisselbrink and Yuri Chornoivan.
> 
> 
> Description
> -------
> 
> Doc Update for Tables 2.4.0
> 
> faq.docbook -> remove it?
> importexport.docbook -> remove it?
> configdialog.docbook -> empty Plugin page, why?
> a11y.docbook -> removed
> functions.docbook -> added as requested by Marjin
> generated with a python script, which reveals a lot of errors
> Summary of Errors in 1090 Functions:
> error_missing_parameter: 1
> error_missing_syntax: 1
> error_missing_example: 37
> error_missing_related: 209
> error_missing_helptxt: 1
> error_args_syntax_comment: 85
> error_optional_syntax_comments: 16
> error_type_description_not_supported: 163
> dead links: COUPDAYBS PRICEDISC PRICE ODDFPRICE
> 
> 
> Diffs
> -----
> 
>   doc/tables/advanced.docbook 42626d5 
>   doc/tables/basics.docbook 2a06be2 
>   doc/tables/commands.docbook bf7ea7e 
>   doc/tables/config.docbook 23f1a29 
>   doc/tables/configdialog.docbook cb00b36 
>   doc/tables/faq.docbook c868744 
>   doc/tables/format.docbook afe5787 
>   doc/tables/functions.docbook PRE-CREATION 
>   doc/tables/importexport.docbook 40c35c9 
>   doc/tables/index.docbook 85a7bbb 
> 
> Diff: http://git.reviewboard.kde.org/r/103614/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120109/7746eeed/attachment.htm>


More information about the calligra-devel mailing list