Failing unit test.

Thorsten Zachmann t.zachmann at zagge.de
Fri Jan 6 19:29:29 GMT 2012


Hello Sebastian,

the test TestNumberStyle::testCurrency fails. See:

http://158.36.191.251:8080/viewLog.html?buildId=5085&tab=buildResultsDiv&buildTypeId=bt6#testId4078

The attached patch solves it for me. However I think that you have tested the 
code and it does work for you. Maybe you have an idea on how to make the test 
more flexible as I think it is dependent on the locale. 

Thorsten

diff --git a/libs/odf/tests/TestNumberStyle.cpp 
b/libs/odf/tests/TestNumberStyle.cpp
index efc775c..27e4a5d 100644
--- a/libs/odf/tests/TestNumberStyle.cpp
+++ b/libs/odf/tests/TestNumberStyle.cpp
@@ -158,7 +158,7 @@ void TestNumberStyle::testCurrency()
     f.formatStr = "-#,###0.00";
     QCOMPARE(escapeLocals(KoOdfNumberStyles::format("0.2", f)), 
QString("0.20"));
     f.formatStr = "";
-    QCOMPARE(escapeLocals(KoOdfNumberStyles::format("0.2", f)), QString("0.20 
$"));
+    QCOMPARE(escapeLocals(KoOdfNumberStyles::format("0.2", f)), QString("$ 
0.20"));
 }
 
 QTEST_MAIN(TestNumberStyle)



More information about the calligra-devel mailing list