Review Request: Don't strip spaces when reading xml

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103568/#review9419
-----------------------------------------------------------

Ship it!


- Boudewijn Rempt


On Dec. 29, 2011, 1:26 p.m., Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103568/
> -----------------------------------------------------------
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Don't strip spaces during loading of the xml. This uses the work of review request #101857 which makes it possible to not strip the spaces.
> 
> In the following line from the document in the bug report we don't get the space between <text:line-break/> <text:s/>
>       
> <text:p text:style-name="Standard">abc <text:s text:c="4"/>5 space<text:line-break/> 1 space<text:line-break/> <text:s/>2 space<text:line-break/> <text:s text:c="2"/>3 space<text:line-break/> <text:s text:c="3"/>4 space<text:line-break/> <text:s text:c="4"/>5 space</text:p>
> 
> and therefore we loose the the space on loading.
> 
> The patch also fixes all occurrences where xml was handled wrongly. 
> 
> 
> This addresses bug 290091.
>     http://bugs.kde.org/show_bug.cgi?id=290091
> 
> 
> Diffs
> -----
> 
>   filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h d64e330 
>   filters/words/docx/DocxXmlDocumentReader.cpp 3fa7294 
>   libs/flake/KoShapeRegistry.cpp 13c6889 
>   libs/odf/KoXmlReader.h 8a09912 
>   libs/odf/KoXmlWriter.cpp ae336e6 
> 
> Diff: http://git.reviewboard.kde.org/r/103568/diff/diff
> 
> 
> Testing
> -------
> 
> Run cstester and fixed all problems that showed regressions. The left over changes fix bugs where we lost blanks before.
> 
> 
> Thanks,
> 
> Thorsten Zachmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120102/65b494a0/attachment.htm>