Review Request: Fixes multi-line artistic text being saved with wrong coordinates for second and following lines

[Friedrich W. H. Kossebau]

> On Feb. 29, 2012, 10:25 p.m., Jan Hambrecht wrote:
> > plugins/artistictextshape/ArtisticTextShape.cpp, lines 1008-1021
> > <http://git.reviewboard.kde.org/r/104115/diff/1/?file=51285#file51285line1008>
> >
> >     This code block is the problem. I added the if block some time ago to save some characters when saving a simple translate tramsformation. Obviously i did not test the multiline text case at all at this point. I would prefer to just revert that change and use the 3 lines from the else block to save the text position and transformation. Hope you don't mind after coming up with a working fix.

Don't mind, as long as the bug is fixed :)


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104115/#review11040
-----------------------------------------------------------


On Feb. 29, 2012, 3:50 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104115/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2012, 3:50 a.m.)
> 
> 
> Review request for Calligra and Jan Hambrecht.
> 
> 
> Description
> -------
> 
> First innocent approach to fix that bug which Works for me (tm)
> 
> No idea though yet if a fix is also needed for the case "layout() != ArtisticTextShape::Straight"?
> 
> 
> This addresses bug 295042.
>     http://bugs.kde.org/show_bug.cgi?id=295042
> 
> 
> Diffs
> -----
> 
>   plugins/artistictextshape/ArtisticTextShape.h 05af662 
>   plugins/artistictextshape/ArtisticTextShape.cpp 301b6c7 
> 
> Diff: http://git.reviewboard.kde.org/r/104115/diff/
> 
> 
> Testing
> -------
> 
> Created a document with a multi-line Artistic Text and saved and loaded that a few times, all lines stayed at their positions between saving and loading.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120229/fabd5ffa/attachment.htm>