Review Request: Saving and reloading a file with an Artistic Text object results in spaces added to the text content each time

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104114/
-----------------------------------------------------------

Review request for Calligra and Jan Hambrecht.


Description
-------

The flag "indentInside" was not set to "false" on writing <text> and <tspan> tokens in ArtisticTextShape::saveSvg(...).
That way the created SVG file could contain indenting spaces inside the <text> and <tspan> tokens, which on reading are interpreted to be spaces belonging to the text.

Attached patch fixes that by setting the flag to true (should be switched to be an enum in some future version, no?).


Diffs
-----

  plugins/artistictextshape/ArtisticTextShape.cpp 301b6c7 

Diff: http://git.reviewboard.kde.org/r/104114/diff/


Testing
-------

Created some artistic text shapes with properties of subtext changed, e.g. color, to get more tspans in the stored SVG, then loaded and saved the file a few times.
No longer any spaces are added to the text.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120229/748d3ca1/attachment.htm>