Review Request: This patch supports the navigation of the text doc in CA according to user's wish

[Shantanu Tushar Jha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104092/#review10953
-----------------------------------------------------------


Two minor issues as listed below, looks good otherwise.
About the page not scrolling to the exact position, looks like some issue with CanvasController. I'll fix it after you push this one.


active/qml/TextDocumentLeftToolbar.qml
<http://git.reviewboard.kde.org/r/104092/#comment8899>

    extra whitespace, please remove. Same on lines 33, 39, 46, 52, 53



active/qml/TextDocumentLeftToolbar.qml
<http://git.reviewboard.kde.org/r/104092/#comment8900>

    maybe choose a better name instead of appendItemsForTest() ? Maybe initializePageIcons or similar


- Shantanu Tushar Jha


On Feb. 27, 2012, 4:13 p.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104092/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2012, 4:13 p.m.)
> 
> 
> Review request for Calligra and Shantanu Tushar Jha.
> 
> 
> Description
> -------
> 
> This patch allows the user to navigate through the pages according the wish. The "page + Number" format will be displayed on the left side of the CA Text doc. Clicking on them the user is expected to reach the top portion of that page selected.
> 
> 
> Diffs
> -----
> 
>   active/qml/TextDocumentLeftToolbar.qml PRE-CREATION 
>   active/src/CATextDocumentHandler.h 8f592f3 
>   active/src/CATextDocumentHandler.cpp 01bfeb0 
> 
> Diff: http://git.reviewboard.kde.org/r/104092/diff/
> 
> 
> Testing
> -------
> 
> Testing done:
> 
> 1) The total number of pages displayed on the left portion is tested and it displays correctly.
> 2) When clicked on a particular page, the user doesn't reaches the exact location. Couldn't figure out
>    the exact issue. Any suggestions?
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120227/a0ee4e89/attachment.htm>