Can "bool KoStore::open(const QString & _name)" take a path?

Friedrich W. H. Kossebau kossebau at kde.org
Wed Feb 15 09:03:38 GMT 2012


Am Mittwoch, 15. Februar 2012, 07:36:11 schrieb Thorsten Zachmann:
> Hello Friedrich,
> 
> On Wednesday, February 15, 2012 00:23:57 Friedrich W. H. Kossebau wrote:
> > Hi,
> > 
> > reading through OD* writing filters I see two variants to open a file at
> > a specifc path for writing. Do both result in the same?
> > 
> > Filterkpr2odf::convert(...) has:
> >     //Save the preview picture
> >     output->enterDirectory("Thumbnails");
> >     output->open("thumbnail.png");
> >     ...
> >     output->leaveDirectory();
> > 
> > Words13OasisGenerator::writePreviewFile() has:
> >     m_store->open("Thumbnails/thumbnail.png");
> 
> Both result in the same.

Okay, thanks for confirming.

> > And is the attached patch fixing typos in the path and file name in
> > Filterkpr2odf::convert(...) okay to commit? Have not tested it, missing
> > a
> > kpr file, simply looks worthwhile to fix.
> 
> Haven't tested either but it looks correct. Please fix.

Will commit then (once I have my connection to the git servers working 
again...). 

Cheers
Friedrich



More information about the calligra-devel mailing list