Can "bool KoStore::open(const QString & _name)" take a path?

Friedrich W. H. Kossebau kossebau at kde.org
Tue Feb 14 23:23:57 GMT 2012


Hi,

reading through OD* writing filters I see two variants to open a file at a 
specifc path for writing. Do both result in the same?

Filterkpr2odf::convert(...) has:

    //Save the preview picture
    output->enterDirectory("Thumbnails");
    output->open("thumbnail.png");
    ...
    output->leaveDirectory();

Words13OasisGenerator::writePreviewFile() has:

    m_store->open("Thumbnails/thumbnail.png");

And is the attached patch fixing typos in the path and file name in 
Filterkpr2odf::convert(...) okay to commit? Have not tested it, missing a kpr 
file, simply looks worthwhile to fix.

Cheers
Friedrich
-------------- next part --------------
A non-text attachment was scrubbed...
Name: thumbnailPathTypos.patch
Type: text/x-patch
Size: 973 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120215/13c99b61/attachment.bin>


More information about the calligra-devel mailing list