Review Request:

[Shantanu Tushar Jha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103863/#review10357
-----------------------------------------------------------

Ship it!


Looks good, just fix the following issue (add the signal and emit it when sheetcount changes, which happens when document finishes loading) and commit&push it :)


active/src/CASpreadsheetHandler.h
<http://git.reviewboard.kde.org/r/103863/#comment8525>

    oops you missed the NOTIFY here, QML will complain if you don't have one and binding magic won't work.


- Shantanu Tushar Jha


On Feb. 4, 2012, 10:42 a.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103863/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2012, 10:42 a.m.)
> 
> 
> Review request for Calligra and Shantanu Tushar Jha.
> 
> 
> Description
> -------
> 
> Hide the left button when user is in the first page of the spreadsheet. Similarly hide the right button when user is in the last page of the spreadsheet.
> 
> 
> Diffs
> -----
> 
>   active/qml/SpreadsheetLeftToolbar.qml ce47af4 
>   active/qml/SpreadsheetRightToolbar.qml cc1ef43 
>   active/src/CASpreadsheetHandler.h 1f21a85 
>   active/src/CASpreadsheetHandler.cpp 8869a2b 
> 
> Diff: http://git.reviewboard.kde.org/r/103863/diff/diff
> 
> 
> Testing
> -------
> 
> Testing was done by opening a spreadsheet doc.
> 1) Initially when the page is loaded, the previous button is not visible and when user navigates through next sheet(s) it appears.
> 2) When user reaches the last sheet, the next button disappears. After that if user navigates to previous slide(s) it does appear.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120205/80e144c3/attachment.htm>