Review Request: save z-index in words by adding a new option to KoShapeSavingContext

Thorsten Zachmann t.zachmann at zagge.de
Sun Feb 5 13:27:20 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103857/#review10348
-----------------------------------------------------------

Ship it!


Please commit after undoing the one change that is wrong.


libs/flake/KoShapeSavingContext.h
<http://git.reviewboard.kde.org/r/103857/#comment8521>

    The , at the end should not be added as it will not compile in pedantic mode-


- Thorsten Zachmann


On Feb. 4, 2012, 7:23 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103857/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2012, 7:23 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> save z-index in words by adding a new option to KoShapeSavingContext
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShape.h 7701acf 
>   libs/flake/KoShape.cpp edf3a74 
>   libs/flake/KoShapeGroup.cpp dd2845d 
>   libs/flake/KoShapeSavingContext.h c73a680 
>   words/part/frames/KWFrame.cpp d8642da 
> 
> Diff: http://git.reviewboard.kde.org/r/103857/diff/diff
> 
> 
> Testing
> -------
> 
> load and save documents and see the z order is now preserved
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120205/b3997ada/attachment.htm>


More information about the calligra-devel mailing list