Review Request: Make the epub filter handle math formulas

[mojtaba shahi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107969/#review24354
-----------------------------------------------------------


I found something, I tested your patch and made an epub from your document sample (sqrt) and it doesn't look right for me.
I unpacked the epub and tryed to open the .xhtml (chapter1.xhtml) with my browser and it got error. I checked and found the problem:
for your file is this:
<math:math>
    <math:semantics>
     <math:msqrt>
      <math:mrow>
       ...
</math:math>

It should be this:
<math>
    <semantics>
     <msqrt>
      <mrow>
       ...
</math>

If i am right, you should remove local name "math".
sorry for my hurry to ship it.

- mojtaba shahi


On Dec. 30, 2012, 4:44 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107969/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2012, 4:44 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch implements support for math formulas in the EPUB filter. This is the first one of the EPUB3 features that we want to add to Calligra 2.7.
> 
> This version only supports math formulas saved as an embedded document, like LibreOffice and the OpenOffice variants save it. Calligra saves math formulas as inline mathML in the frame, which is not supported by this version. I thought that I could get some initial feedback while implementing support for the Calligra way too.
> 
> 
> Diffs
> -----
> 
>   filters/words/epub/OdfParser.cpp 6069b89 
>   filters/words/epub/OdtHtmlConverter.h 68aaffa 
>   filters/words/epub/OdtHtmlConverter.cpp e5e0edc 
>   filters/words/epub/TODO e634a05 
>   filters/words/epub/exportepub2.cpp cfd50c3 
>   filters/words/epub/exporthtml.cpp 5bb44aa 
> 
> Diff: http://git.reviewboard.kde.org/r/107969/diff/
> 
> 
> Testing
> -------
> 
> Created one simple odt using OOo which has a formula and some text.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121231/5f1a44d0/attachment.htm>