Review Request: Implement line smoothing using sigetch's algorithm

[Lukáš Tvrdý]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108049/#review24333
-----------------------------------------------------------


Looks good to me. I did not test, I just looked at the code. I would wait for one more reviewer at least.

Please don't remove non-smoothed strokes.


krita/ui/tool/kis_tool_freehand_helper.cpp
<http://git.reviewboard.kde.org/r/108049/#comment18673>

    Please, don't remove the option where you can completely turn off smoothing.
    
    It can be useful for some brush engines that require raw mouse/tablet input and which do some kind of own smoothing or interpret the raw input somehow. E.g. experimental (Shape) brush engine in some settings is nice with non-smooth strokes. 
    
    There might exists some smoothing also on driver level? And users might want to  test that smoothing too, so let's give him this option. 


- Lukáš Tvrdý


On Dec. 31, 2012, 1:01 p.m., Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108049/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2012, 1:01 p.m.)
> 
> 
> Review request for Calligra, Cyrille Berger Skott, Dmitry Kazakov, Lukáš Tvrdý, and Sven Langkamp.
> 
> 
> Description
> -------
> 
> This patch ports the smoothing algorithm from http://www24.atwiki.jp/sigetch_2007/pages/17.html (as implemented in Gimp 2.8) to Krita. The previous smoothing algorithm now is the unsmoothed default, and the old completely unsmoothed option has gone.
> 
> 
> This addresses bug 281267.
>     http://bugs.kde.org/show_bug.cgi?id=281267
> 
> 
> Diffs
> -----
> 
>   krita/image/brushengine/kis_paint_information.h 0142a33 
>   krita/image/kis_distance_information.h c1ab409 
>   krita/plugins/paintops/libpaintop/sensors/kis_dynamic_sensors.cc 16473f5 
>   krita/plugins/tools/defaulttools/kis_tool_brush.h f849233 
>   krita/plugins/tools/defaulttools/kis_tool_brush.cc 536b81d 
>   krita/ui/tool/kis_tool_freehand.h ee915d8 
>   krita/ui/tool/kis_tool_freehand.cc 5640a4b 
>   krita/ui/tool/kis_tool_freehand_helper.h 4978c85 
>   krita/ui/tool/kis_tool_freehand_helper.cpp dde51ea 
> 
> Diff: http://git.reviewboard.kde.org/r/108049/diff/
> 
> 
> Testing
> -------
> 
> Animtim has tested the branch:
> 
> 14:00:14 < Animtim_> boud: perfect
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121231/d2a0b86a/attachment.htm>