Review Request: spellchecking changes

C. Boemann cbr at boemann.dk
Sun Dec 30 13:51:11 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108022/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

Change the way we draw markings of speeling errors. Instead of using the qt way we draw it ourselve
This has the following benefits:
  - we don't have to relayout after finding spelling errors
  - we can have more than one type of marking (spelling, grammar, etc)

This commit also changes the way we ask for spellchecking to be performed. The old way had some
shortcommings that could lead to text not being checked at all


Diffs
-----

  libs/kotext/KoTextBlockData.h 05db499 
  libs/kotext/KoTextBlockData.cpp b1d7d5c 
  libs/kotext/KoTextEditingPlugin.h 7b7b9dd 
  libs/textlayout/KoTextLayoutArea.h 94c52ec 
  libs/textlayout/KoTextLayoutArea_paint.cpp 2fc2131 
  libs/textlayout/KoTextLayoutRootAreaProvider.h d8c0614 
  libs/textlayout/KoTextLayoutRootAreaProvider.cpp 7d27944 
  plugins/textediting/autocorrection/Autocorrect.h 2a84506 
  plugins/textediting/autocorrection/Autocorrect.cpp e136216 
  plugins/textediting/changecase/Changecase.h 8433be1 
  plugins/textediting/changecase/Changecase.cpp 936957c 
  plugins/textediting/spellcheck/CMakeLists.txt a4dedef 
  plugins/textediting/spellcheck/SpellCheck.h ee2f7bf 
  plugins/textediting/spellcheck/SpellCheck.cpp 4da7e7d 
  plugins/textediting/thesaurus/Thesaurus.h c5de5b0 
  plugins/textediting/thesaurus/Thesaurus.cpp b10a69d 
  plugins/textshape/SimpleRootAreaProvider.h 8daf2f8 
  plugins/textshape/SimpleRootAreaProvider.cpp 1f3b0fe 
  plugins/textshape/TextTool.h a8a525d 
  plugins/textshape/TextTool.cpp 148806c 
  words/part/KWRootAreaProvider.h 1908b11 
  words/part/KWRootAreaProvider.cpp 9e28045 

Diff: http://git.reviewboard.kde.org/r/108022/diff/


Testing
-------

played around with it


Thanks,

C. Boemann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121230/347315e7/attachment.htm>


More information about the calligra-devel mailing list