Review Request: Fix sorting of style names

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108020/#review24224
-----------------------------------------------------------

Ship it!


yes please backport too

great work

- C. Boemann


On Dec. 30, 2012, 9:08 a.m., Pierre Stirnweiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108020/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2012, 9:08 a.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> The style names containing a number were not sorted with natural order : Content 1/Content 10/Content 2.
> This is because QString::localeAwareCompare does not sort with natural order. Use KSTringHandler::naturalCompare instead (it also uses QString::localeAwareCompare internally).
> 
> Ok to backport?
> 
> 
> This addresses bug 288651.
>     http://bugs.kde.org/show_bug.cgi?id=288651
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/dialogs/DockerStylesComboModel.cpp c1ffaa1 
>   plugins/textshape/dialogs/StylesModel.cpp 4b1b9f6 
> 
> Diff: http://git.reviewboard.kde.org/r/108020/diff/
> 
> 
> Testing
> -------
> 
> Styles are sorted in natural order now. I could not test regressions where locale comparison would play a role however. But since KStringHandler's comparison uses the Qt one, I don't expect a regression there.
> 
> 
> Thanks,
> 
> Pierre Stirnweiss
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121230/e2211f2d/attachment.htm>