Review Request: Make a real dynamic library out of kdgantt

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108019/#review24216
-----------------------------------------------------------


I think the code looks nice enough, so stuart are free to approve as far as i'm concerned.

I have one little question/nitpick


3rdparty/kdgantt/CMakeLists.txt
<http://git.reviewboard.kde.org/r/108019/#comment18557>

    uhm i don't get why we can't remove it already.
    


- C. Boemann


On Dec. 30, 2012, 5:21 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108019/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2012, 5:21 a.m.)
> 
> 
> Review request for Calligra and Stuart Dickson.
> 
> 
> Description
> -------
> 
> This is an adaption of the same patch for 2.6.
> 
> This patch needs to be tested on Windows, which I hope stuart can do.
> 
> 
> Diffs
> -----
> 
>   3rdparty/kdgantt/CMakeLists.txt 4a75084 
>   3rdparty/kdgantt/kdganttconstraintmodel.h bc1ed5c 
>   3rdparty/kdgantt/kdganttview.cpp a09edf1 
>   CMakeLists.txt 09d98be 
>   plan/libs/ui/CMakeLists.txt c80f891 
>   plan/workpackage/CMakeLists.txt 7ebedce 
> 
> Diff: http://git.reviewboard.kde.org/r/108019/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121230/60fcdc57/attachment.htm>