Review Request: Remove usage of toAscii/fromAscii (basically replace with toLatin/fromLatin)

Commit Hook null at kde.org
Fri Dec 28 22:23:13 GMT 2012 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107871/#review24142
-----------------------------------------------------------


This review has been submitted with commit f56a9458000aaf06e5edfdd753b6d25c3d4a1485 by Friedrich W. H. Kossebau to branch master.

- Commit Hook


On Dec. 23, 2012, 1:54 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107871/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2012, 1:54 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Boudewijn Rempt.
> 
> 
> Description
> -------
> 
> Done as simple side task when listening to QtDD12 videos, as most, if not all changes where no-brainers :)
> Touching mostly Kexi/Krita, so putting boud and jaros?aw as reviewers.
> 
> toAscii/fromAscii has the problem to depend on the globally set QTextCodec::setCodecForCStrings(), so has the small risk of not working as expected.
> 
> also:
> * use implicit conversion from toLatin1-QByteArray to const char*, where possible
> * constData() instead of data() everywhere, to avoid unneeded deep copies if code get copied
> * removed unneeded conversion to latin1 where QString was expected
> * use QByteArray instead of QString, if QString not really needed
> * cache result of conversion where useful
> 
> 
> Diffs
> -----
> 
>   filters/karbon/image/ImageExport.cpp 9852637 
>   filters/karbon/pdf/SvgOutputDev.cpp e0b203d 
>   filters/sheets/excel/sidewinder/XlsRecordOutputStream.cpp c15ccf1 
>   filters/sheets/excel/sidewinder/formulas.cpp ff3aae9 
>   filters/sheets/excel/sidewinder/recordsxml2cpp.cpp cba7d0c 
>   filters/sheets/excel/sidewinder/utils.cpp d81a424 
>   filters/sheets/xlsx/XlsxUtils.h cc0ec59 
>   filters/sheets/xlsx/XlsxXmlChartReader.cpp 73c3eac 
>   filters/sheets/xlsx/XlsxXmlWorksheetReader.cpp 99c3eb5 
>   filters/stage/powerpoint/PptToOdp.cpp 6947853 
>   filters/words/mobi/PalmDocCompression.cpp 1c1c517 
>   filters/words/rtf/import/rtf-qt/src/PictDestination.cpp 16c62e6 
>   kexi/formeditor/commands.cpp 02ae04d 
>   kexi/formeditor/formIO.cpp ce68111 
>   kexi/formeditor/utils.cpp 4b4974b 
>   kexi/kexidb/drivers/odbc/odbcdriver.cpp 98e77f1 
>   kexi/kexidb/drivers/odbc/odbcspecialcolumnsqueryunit.cpp 1e951f1 
>   kexi/kexidb/drivers/odbc/odbctablesqueryunit.cpp 6f9f3ff 
>   kexi/kexidb/drivers/pqxx/pqxxdriver.cpp 8a27c73 
>   kexi/kexidb/drivers/sybase/sybaseconnection.cpp 27d8b19 
>   kexi/kexidb/drivers/xbase/xbaseexport.cpp 7f64a6d 
>   kexi/tests/newapi/parser_test.h 2a631f8 
>   krita/image/kis_count_visitor.cpp b97165b 
>   krita/image/kis_node.cpp c3fabef 
>   krita/image/tests/kis_action_recorder_test.cpp 65d97d0 
>   krita/image/tests/kis_convolution_painter_test.cpp c1dc024 
>   krita/image/tests/kis_cs_conversion_test.cpp dc5b7b4 
>   krita/image/tests/kis_filter_job_test.cpp 0b779ef 
>   krita/image/tests/kis_filter_mask_test.cpp 2cbd248 
>   krita/image/tests/kis_filter_test.cpp d7b66b7 
>   krita/image/tests/kis_fixed_paint_device_test.cpp 8b48ee8 
>   krita/image/tests/kis_paint_device_test.cpp 8554727 
>   krita/image/tests/kis_paint_layer_test.cpp 573ed5f 
>   krita/image/tests/kis_selection_test.cpp 27049c8 
>   krita/image/tests/kis_transform_worker_test.cpp 2c5bf9a 
>   krita/image/tests/kis_transparency_mask_test.cpp 23308bb 
>   krita/image/tiles3/kis_tiled_data_manager.cc ab89aa2 
>   krita/image/tiles3/swap/kis_tile_compressor_2.cpp c468439 
>   krita/plugins/extensions/dockers/lut/ocio_display_filter.cpp 6e39ab7 
>   krita/plugins/extensions/metadataeditor/kis_entry_editor.cc a9df3b4 
>   krita/plugins/extensions/metadataeditor/kis_meta_data_editor.cc 3da27c5 
>   krita/plugins/extensions/shiva/ShivaGeneratorConfigWidget.cpp b197538 
>   krita/plugins/extensions/shiva/shivafilter.cpp 7ff5448 
>   krita/plugins/extensions/shiva/shivafiltersplugin.cpp cd412cd 
>   krita/plugins/extensions/shiva/shivagenerator.cpp 6373663 
>   krita/plugins/extensions/shiva/shivageneratorsplugin.cpp 6a6e5f8 
>   krita/plugins/filters/colorsfilters/kis_perchannel_filter.cpp d6886f2 
>   krita/plugins/filters/tests/kis_all_filter_test.cpp 1ee1985 
>   krita/plugins/filters/tests/kis_crash_filter_test.cpp ccaa585 
>   krita/plugins/formats/exr/exr_converter.cc a8cf9a1 
>   krita/plugins/formats/psd/psd_layer_record.cpp cb51543 
>   krita/plugins/formats/psd/psd_utils.cpp 618abb1 
>   krita/plugins/formats/tiff/kis_tiff_converter.cc e3bb4c0 
>   krita/plugins/paintops/libbrush/kis_gbr_brush.cpp 97011ff 
>   krita/plugins/paintops/libbrush/tests/kis_auto_brush_test.cpp 49097a9 
>   krita/plugins/paintops/libbrush/tests/kis_brush_test.cpp dff42e7 
>   krita/plugins/paintops/libpaintop/kis_texture_option.cpp a40b0fb 
>   krita/plugins/paintops/mypaint/mypaint_paintop_factory.cpp deca471 
>   krita/ui/kis_clipboard.cc 720bb34 
>   krita/ui/kis_png_converter.cpp 7d9ee48 
>   krita/ui/kis_workspace_resource.cpp 71e4a6f 
>   krita/ui/kisexiv2/kis_exif_io.cpp eb4f232 
>   krita/ui/kisexiv2/kis_exiv2.cpp 9f06ff9 
>   krita/ui/kisexiv2/kis_xmp_io.cpp f43c68b 
>   krita/ui/opengl/kis_opengl_shader.cpp a6febe9 
>   libs/flake/KoUnavailShape.cpp a15f369 
>   libs/kotext/opendocument/KoTextWriter_p.cpp c302522 
>   libs/kotext/styles/KoCharacterStyle.cpp dec30a9 
>   libs/main/KoDocumentInfo.cpp 7e0f221 
>   libs/main/KoFilterChain.cpp d10d7b6 
>   libs/main/KoMainWindow.cpp b10eb26 
>   libs/odf/KoEncryptedStore.cpp 6a4b1a7 
>   libs/odf/KoProperties.cpp c4792df 
>   libs/odf/tests/storedroptest.cpp 1f48135 
>   libs/pigment/resources/KoColorSet.cpp 4c6c924 
>   libs/pigment/resources/KoPattern.cpp f357520 
>   libs/widgets/KoResourceServer.h c3ac731 
>   libs/widgets/KoResourceServerProvider.cpp 2d927dc 
>   plan/libs/models/kptitemmodelbase.cpp faf61e6 
>   plan/plugins/schedulers/rcps/KPlatoRCPSScheduler.cpp f4472b4 
>   plugins/chartshape/CellRegion.cpp 0cf2b66 
>   plugins/chartshape/ChartTableModel.cpp d478b51 
>   plugins/chartshape/tests/TestDataSet.cpp 72c35b0 
>   plugins/chartshape/tests/TestProxyModel.cpp d6045d4 
>   plugins/chartshape/tests/odf/TestLoadingBase.cpp ede37aa0 
>   plugins/colorengines/lcms2/IccColorSpaceEngine.cpp ef8f5e6 
>   plugins/colorengines/lcms2/colorprofiles/LcmsColorProfileContainer.cpp 393db27 
>   plugins/colorengines/lcms2/tests/TestKoColorSpaceRegistry.cpp a00afe8 
>   plugins/formulashape/Dictionary.cpp 43713b6 
>   plugins/musicshape/core/MusicXmlReader.cpp e9edede 
>   plugins/pathshapes/enhancedpath/EnhancedPathFormula.cpp 48e977a 
>   plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 046e489 
>   plugins/reporting/barcode/3of9.cpp 4eb5450 
>   plugins/reporting/barcode/3of9paint.cpp 57547c6 
>   plugins/reporting/barcode/code128.cpp 5a1e373 
>   plugins/reporting/barcode/code128paint.cpp 6ae01fe 
>   plugins/reporting/barcode/ext3of9.cpp b612095 
>   plugins/reporting/barcode/ext3of9paint.cpp 2d3b3f0 
>   sheets/Global.h 1759095 
> 
> Diff: http://git.reviewboard.kde.org/r/107871/diff/
> 
> 
> Testing
> -------
> 
> No changes in output of test run.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121228/fb73fcdc/attachment.htm>

More information about the calligra-devel mailing list