Review Request: basicflakes library

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107979/#review24103
-----------------------------------------------------------

Ship it!


I haven't compiled it, but it looks good enough to go for me.

- Boudewijn Rempt


On Dec. 28, 2012, 1:13 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107979/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2012, 1:13 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This commit creates a basicflakes library, which for now holds only the KoCreatePathTool
> 
> Krita (used the class to make a superclass - for some special tools) is adapted to use the new library instead of flake.
>  
> The library also installs a plugin so the tool is available as before
> 
> Final change is that the CreatePath tool no longer has a snapping option widget (in master we already have a new docker which holds the snapping options)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ce8f560 
>   krita/CMakeLists.txt 65f1653 
>   krita/plugins/tools/defaulttools/CMakeLists.txt 6a38fc0 
>   krita/plugins/tools/selectiontools/CMakeLists.txt e77765a 
>   libs/CMakeLists.txt 110c3eb 
>   libs/basicflakes/CMakeLists.txt PRE-CREATION 
>   libs/basicflakes/plugin/CMakeLists.txt PRE-CREATION 
>   libs/basicflakes/plugin/KoCreatePathToolFactory.h PRE-CREATION 
>   libs/basicflakes/plugin/KoCreatePathToolFactory.cpp PRE-CREATION 
>   libs/basicflakes/plugin/Plugin.h PRE-CREATION 
>   libs/basicflakes/plugin/Plugin.cpp PRE-CREATION 
>   libs/basicflakes/plugin/basicflakesplugin.desktop PRE-CREATION 
>   libs/basicflakes/tools/KoCreatePathTool.h PRE-CREATION 
>   libs/basicflakes/tools/KoCreatePathTool.cpp PRE-CREATION 
>   libs/basicflakes/tools/KoCreatePathTool_p.h PRE-CREATION 
>   libs/flake/CMakeLists.txt 62bc2dc 
>   libs/flake/KoToolRegistry.cpp 0ceb40e 
>   libs/flake/tools/KoCreatePathTool.h 5b0ae7e 
>   libs/flake/tools/KoCreatePathTool.cpp 8dfbe34 
>   libs/flake/tools/KoCreatePathToolFactory.h 1db235e 
>   libs/flake/tools/KoCreatePathToolFactory.cpp f14139c 
>   libs/flake/tools/KoCreatePathTool_p.h 3bdedd7 
> 
> Diff: http://git.reviewboard.kde.org/r/107979/diff/
> 
> 
> Testing
> -------
> 
> Have reinstalled from scratch and seen that the tools are still there and works.
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121228/2c7f8669/attachment.htm>