Review Request: Fix clicking in selection does not update caret

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107849/#review23854
-----------------------------------------------------------

Ship it!


yes sure, but could you please change all the initializers to:
 , m_sometihng(xx)

rather than the other way

and ok to backport

- C. Boemann


On Dec. 22, 2012, 4:47 p.m., Pierre Stirnweiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107849/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2012, 4:47 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> When clicking inside a selection in the TextTool, the caret does not update to the new position. Seems to be linked to the uninitialized m_drag (don't ask why). It is a good idea to initialize anyway.
> 
> Ok to backport?
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/TextTool.cpp 24f50e2 
> 
> Diff: http://git.reviewboard.kde.org/r/107849/diff/
> 
> 
> Testing
> -------
> 
> Now it works for me ;)
> 
> 
> Thanks,
> 
> Pierre Stirnweiss
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121222/1e298681/attachment.htm>