Review Request: Implement triple button widget

[Jean-Nicolas Artaud]

> On Dec. 20, 2012, 11:34 p.m., Jarosław Staniek wrote:
> > For a test I added three buttons switching views in Kexi.
> > 
> > - A mockup how that would look:
> > http://kexi-project.org/pics/2.7/groupbutton/triple1-mockup.png
> > 
> > Screenshots:
> > - actual look using your newest revision 8: http://kexi-project.org/pics/2.7/groupbutton/triple2-actual.png
> > - proposed final look: http://kexi-project.org/pics/2.7/groupbutton/triple7-final.png - I am unable to remove space between buttons; it somehow comes from the style. So it's not like the mockup but close and usable.
> > - the final look with Cleanlooks style: http://kexi-project.org/pics/2.7/groupbutton/triple6-cleanlooks.png it needs some work later
> > 
> > The widget looks OK on 'exotic' styles such as Windows.
> > 
> > If that's OK, I propose to commit the 'final' look - KoGroupButton.cpp code modified by me: http://paste.kde.org/629012/raw/ - already contains fixes I proposed.
> > 
> > I think we need to start somewhere and eat this dog food.
> 
> C. Boemann wrote:
>     i like your idea in the mockup and think it works for most styles i can think of without looking too weird
>     
>     But how about calculating a correct panel rect to cover all the buttons. Then there will be no space on windows either. The manually drawn seperators will have to be tweaked too, but that should be doable.
> 
> Jarosław Staniek wrote:
>     I can put the code as libkowidgetutils in libs/widgetutils/.
> 
> Jarosław Staniek wrote:
>     OK, please review: https://git.reviewboard.kde.org/r/107842/

Ok, thanks Jeroslaw for all these tests and answers.
I'll update a new diff ASAP here fixing the troubles you pointed me.

I'm not wise enough to answer if a new lib is needed or not, I'll let you fight on this point :-)

Thank you.


- Jean-Nicolas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107530/#review23784
-----------------------------------------------------------


On Dec. 18, 2012, 2:46 p.m., Jean-Nicolas Artaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107530/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 2:46 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Implement triple button widget in the calligra widget libs.
> This also can be used for double buttons (like in gwenview for instance).
> 
> 
> Diffs
> -----
> 
>   libs/widgets/CMakeLists.txt 10e4e09 
>   libs/widgets/KoGroupButton.h PRE-CREATION 
>   libs/widgets/KoGroupButton.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107530/diff/
> 
> 
> Testing
> -------
> 
> Use the triple button on the property docker.
> 
> 
> Screenshots
> -----------
> 
> Strocke properties docker with the triple buttons
>   http://git.reviewboard.kde.org/r/107530/s/865/
> MS Word uses it every where
>   http://git.reviewboard.kde.org/r/107530/s/869/
> Normal Mode, Normal Size
>   http://git.reviewboard.kde.org/r/107530/s/875/
> Flat Mode, Normal Size
>   http://git.reviewboard.kde.org/r/107530/s/876/
> 
> 
> Thanks,
> 
> Jean-Nicolas Artaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121222/2ec62057/attachment.htm>