Review Request: Introduce kowidgetutils library and put KoGroupButton in it

Jarosław Staniek staniek at kde.org
Fri Dec 21 23:16:49 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107842/
-----------------------------------------------------------

Review request for Calligra, Jean-Nicolas Artaud, Adam Pigg, Dimitrios Tanis, Radosław Wicik, and Oleg Kukharchuk.


Description
-------

Introduce kowidgetutils library to Calligra libs 2.7 and put KoGroupButton in it. 

The KoGroupButton's code is untouched (except for the EXPORT name) and comes from Jean-Nicolas Artaud - see https://git.reviewboard.kde.org/r/107530 so please do not report issues related to it here. In that patch KoGroupButton was put into kowidgets library what's suboptimal because of dependencies - no point to depend on kotext, etc. to use one unrelated widget.

This change is s small step to increase modularity.

More classes to come here, including improvements to KoGroupButton.


Diffs
-----

  libs/CMakeLists.txt 531873f7e8fb3c8f1f7f49d3d355e9f6e537ac2b 
  libs/widgetutils/CMakeLists.txt PRE-CREATION 
  libs/widgetutils/KoGroupButton.h PRE-CREATION 
  libs/widgetutils/KoGroupButton.cpp PRE-CREATION 
  libs/widgetutils/README PRE-CREATION 
  libs/widgetutils/kowidgetutils_export.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107842/diff/


Testing
-------

Tested in Kexi


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121221/2b4049da/attachment.htm>


More information about the calligra-devel mailing list