Review Request: Implement triple button widget

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107530/#review23743
-----------------------------------------------------------


I've tested it with Kexi. Does its job quite nice already. Apart from the possible visual improvements (I'll experiment here), I found a number of usage issues, please see below.


libs/widgets/KoGroupButton.cpp
<http://git.reviewboard.kde.org/r/107530/#comment18163>

    This attribute isn't needed if we pass the parent to QToolButton.



libs/widgets/KoGroupButton.cpp
<http://git.reviewboard.kde.org/r/107530/#comment18162>

    Missing QToolButton(parent) call, what makes the widget invisible and uninitialized.



libs/widgets/KoGroupButton.cpp
<http://git.reviewboard.kde.org/r/107530/#comment18164>

    not needed, this is the default, so it's unsafe to repeat it here



libs/widgets/KoGroupButton.cpp
<http://git.reviewboard.kde.org/r/107530/#comment18165>

    not needed - this is not safe or unexpected default



libs/widgets/KoGroupButton.cpp
<http://git.reviewboard.kde.org/r/107530/#comment18166>

    similarly - not neede, default preferred size works better for me, if not, users can override it


- Jarosław Staniek


On Dec. 18, 2012, 2:46 p.m., Jean-Nicolas Artaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107530/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 2:46 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Implement triple button widget in the calligra widget libs.
> This also can be used for double buttons (like in gwenview for instance).
> 
> 
> Diffs
> -----
> 
>   libs/widgets/CMakeLists.txt 10e4e09 
>   libs/widgets/KoGroupButton.h PRE-CREATION 
>   libs/widgets/KoGroupButton.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107530/diff/
> 
> 
> Testing
> -------
> 
> Use the triple button on the property docker.
> 
> 
> Screenshots
> -----------
> 
> Strocke properties docker with the triple buttons
>   http://git.reviewboard.kde.org/r/107530/s/865/
> MS Word uses it every where
>   http://git.reviewboard.kde.org/r/107530/s/869/
> Normal Mode, Normal Size
>   http://git.reviewboard.kde.org/r/107530/s/875/
> Flat Mode, Normal Size
>   http://git.reviewboard.kde.org/r/107530/s/876/
> 
> 
> Thanks,
> 
> Jean-Nicolas Artaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121219/4cb3f89b/attachment.htm>