Review Request: Port KoProperty editors for Date, Time & DateTime to Qt4 and enable again

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107792/#review23709
-----------------------------------------------------------


This review has been submitted with commit a9fbc6ee851cd27903db2aebc0e2835d3d20b040 by Friedrich W. H. Kossebau to branch master.

- Commit Hook


On Dec. 18, 2012, 12:03 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107792/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 12:03 a.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> The KoProperty editors for Date, Time & DateTime were disabled from the build, because still relying on Q3 classes.
> 
> Attached patch ports them to the current approach with EditorCreatorInterface and ValueDisplayInterface.
> It also adds support for some min and max options for Date and Time, but then these options are not yet used.
> Still okay to have them, or better remove? If to keep them, where could these options be announced, so they can be used in client code?
> 
> I enabled the Calendarbutton for Date and DateTime editors, okay or not?
> 
> Nitpick is that the upper line of the cell is overdrawn by the editor widgets, but I have no real idea how to stop that.
> Would propose to have this fixed separately, if somebody finds a nice solution.
> 
> 
> Diffs
> -----
> 
>   libs/koproperty/CMakeLists.txt 05e7032 
>   libs/koproperty/DefaultFactory.cpp 976d967 
>   libs/koproperty/editors/dateedit.h 5c1b542 
>   libs/koproperty/editors/dateedit.cpp a760fe3 
>   libs/koproperty/editors/datetimeedit.h f910012 
>   libs/koproperty/editors/datetimeedit.cpp 046759b 
>   libs/koproperty/editors/timeedit.h 149ee71 
>   libs/koproperty/editors/timeedit.cpp 11acf75 
> 
> Diff: http://git.reviewboard.kde.org/r/107792/diff/
> 
> 
> Testing
> -------
> 
> Seems to work fine in calligra/libs/koproperty/test/propertytest.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121218/4a8f5cf8/attachment.htm>