[calligra] /: Move the external library kdchart from the chart shape to 3rdparty/.

[Jaroslaw Staniek]

On 18 December 2012 20:05, C. Boemann <cbo at boemann.dk> wrote:
> On Tuesday 18 December 2012 19:42:13 Thorsten Zachmann wrote:
>> On Tuesday 18 December 2012 19:29:39 Inge Wallin wrote:
>> > On Sunday, December 16, 2012 17:02:40 Inge Wallin wrote:
>> > > Git commit 3dbbc7afa43e548177eabea821ccdc18bd982566 by Inge Wallin.
>> > > Committed on 16/12/2012 at 16:50.
>> > > Pushed by ingwa into branch 'master'.
>> > >
>> > > Move the external library kdchart from the chart shape to 3rdparty/.
>> >
>> > Ok to cherry-pick to 2.6?
>>
>> I don't think we win anything by doing this and just risk stuff. E.g.
>> packagers need to redo their work and I'm against doing something like
>> that, that late in the release cycle.
>>
>> Thorsten
> I wouldn't say we win nothing. The point of this change is to make it build on
> windows.
>
> That said I think it's very late indeed. we should release another RC for sure
> if we do

IMHO Breaking packages at this stage and for this very reason would be
unfortunate. The windows build is different - it's packaged by "us".
Therefore we can point to _any_ branch, tag or hash in our packaging
recipe and we'll be OK. Or a "windows" branch like Thorsten
suggests. Call this "distributor's patching". In the future (2.7?)
we'd be back to vanilla Calligra.

-- 
regards / pozdrawiam, Jaroslaw Staniek
 Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org
 Qt Certified Specialist | http://qt-project.org
 http://www.linkedin.com/in/jstaniek