Review Request: Added retina compatible (1024x1024) icons for most apps.

Inge Wallin inge at lysator.liu.se
Sun Dec 16 09:37:47 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107753/#review23519
-----------------------------------------------------------


The patch itself looks fine.

But I wonder: Is it really necessary to install icons with that high resolution? I thought that's why we use SVG to begin with, to get scalability. In very low resolutions there is often need for manual tweaking but is this also true at 256x256 and up?

- Inge Wallin


On Dec. 16, 2012, 7:49 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107753/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2012, 7:49 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Added retina compatible (1024x1024) icons for most apps.
> 
> 
> Diffs
> -----
> 
>   braindump/data/icons/hi1024-app-braindump.png PRE-CREATION 
>   braindump/data/icons/hi128-app-braindump.png PRE-CREATION 
>   braindump/data/icons/hi256-app-braindump.png PRE-CREATION 
>   braindump/data/icons/hi512-app-braindump.png PRE-CREATION 
>   braindump/data/icons/hi64-app-braindump.png PRE-CREATION 
>   braindump/src/CMakeLists.txt c009e20 
>   flow/CMakeLists.txt 571e87e 
>   flow/part/CMakeLists.txt 41a9ecf 
>   flow/pics/CMakeLists.txt PRE-CREATION 
>   flow/pics/hi1024-app-calligraflow.png PRE-CREATION 
>   flow/pics/hi128-app-calligraflow.png PRE-CREATION 
>   flow/pics/hi16-app-calligraflow.png PRE-CREATION 
>   flow/pics/hi256-app-calligraflow.png PRE-CREATION 
>   flow/pics/hi32-app-calligraflow.png PRE-CREATION 
>   flow/pics/hi512-app-calligraflow.png PRE-CREATION 
>   flow/pics/hi64-app-calligraflow.png PRE-CREATION 
>   flow/pics/hisc-app-calligraflow.svgz PRE-CREATION 
>   karbon/pics/app/hi1024-app-karbon.png PRE-CREATION 
>   karbon/pics/app/hi128-app-karbon.png PRE-CREATION 
>   karbon/pics/app/hi16-app-karbon.png 47f1a67 
>   karbon/pics/app/hi22-app-karbon.png 5ed414d 
>   karbon/pics/app/hi256-app-karbon.png PRE-CREATION 
>   karbon/pics/app/hi32-app-karbon.png 9783605 
>   karbon/pics/app/hi48-app-karbon.png 09fb40f 
>   karbon/pics/app/hi512-app-karbon.png PRE-CREATION 
>   karbon/pics/app/hi64-app-karbon.png PRE-CREATION 
>   karbon/pics/app/hisc-app-karbon.svgz e757469 
>   kexi/CMakeLists.txt 4afc425 
>   krita/CMakeLists.txt 6641610 
>   krita/pics/hi1024-app-krita.png PRE-CREATION 
>   krita/pics/hi512-app-krita.png PRE-CREATION 
>   plan/pics/hi1024-app-calligraplan.png PRE-CREATION 
>   plan/pics/hi256-app-calligraplan.png PRE-CREATION 
>   plan/pics/hi512-app-calligraplan.png PRE-CREATION 
>   sheets/CMakeLists.txt 1544b58 
>   sheets/data/pics/hi1024-app-calligrasheets.png PRE-CREATION 
>   sheets/data/pics/hi128-app-calligrasheets.png PRE-CREATION 
>   sheets/data/pics/hi16-app-calligrasheets.png PRE-CREATION 
>   sheets/data/pics/hi16-app-sheets.png 2fc3d86 
>   sheets/data/pics/hi22-app-calligrasheets.png PRE-CREATION 
>   sheets/data/pics/hi22-app-sheets.png 9f8c807 
>   sheets/data/pics/hi256-app-calligrasheets.png PRE-CREATION 
>   sheets/data/pics/hi32-app-calligrasheets.png PRE-CREATION 
>   sheets/data/pics/hi32-app-sheets.png 5161357 
>   sheets/data/pics/hi48-app-calligrasheets.png PRE-CREATION 
>   sheets/data/pics/hi48-app-sheets.png b908ae9 
>   sheets/data/pics/hi512-app-calligrasheets.png PRE-CREATION 
>   sheets/data/pics/hi64-app-calligrasheets.png PRE-CREATION 
>   sheets/data/pics/hisc-app-calligrasheets.svgz PRE-CREATION 
>   stage/part/CMakeLists.txt ab45f1d 
>   stage/pics/hi1024-app-calligrastage.png PRE-CREATION 
>   stage/pics/hi128-app-calligrastage.png PRE-CREATION 
>   stage/pics/hi16-app-calligrastage.png PRE-CREATION 
>   stage/pics/hi16-app-stage.png 76bd391 
>   stage/pics/hi22-app-calligrastage.png PRE-CREATION 
>   stage/pics/hi22-app-stage.png d2a21d9 
>   stage/pics/hi256-app-calligrastage.png PRE-CREATION 
>   stage/pics/hi32-app-calligrastage.png PRE-CREATION 
>   stage/pics/hi32-app-stage.png e75e9e4 
>   stage/pics/hi48-app-calligrastage.png PRE-CREATION 
>   stage/pics/hi48-app-stage.png 0fff633 
>   stage/pics/hi512-app-calligrastage.png PRE-CREATION 
>   stage/pics/hi64-app-calligrastage.png PRE-CREATION 
>   stage/pics/hisc-app-calligrastage.svgz PRE-CREATION 
>   words/part/CMakeLists.txt 3dca430 
>   words/pics/hi1024-app-calligrawords.png PRE-CREATION 
>   words/pics/hi128-app-calligrawords.png PRE-CREATION 
>   words/pics/hi16-app-calligrawords.png PRE-CREATION 
>   words/pics/hi16-app-words.png 8c63f72 
>   words/pics/hi22-app-calligrawords.png PRE-CREATION 
>   words/pics/hi22-app-words.png ef8fbef 
>   words/pics/hi256-app-calligrawords.png PRE-CREATION 
>   words/pics/hi32-app-calligrawords.png PRE-CREATION 
>   words/pics/hi32-app-words.png 60dc06d 
>   words/pics/hi48-app-calligrawords.png PRE-CREATION 
>   words/pics/hi48-app-words.png 5a401ec 
>   words/pics/hi512-app-calligrawords.png PRE-CREATION 
>   words/pics/hi64-app-calligrawords.png PRE-CREATION 
>   words/pics/hi64-app-words.png f6d448c 
>   words/pics/hisc-app-calligrawords.svgz PRE-CREATION 
>   words/pics/hisc-app-words.svgz 3290137 
> 
> Diff: http://git.reviewboard.kde.org/r/107753/diff/
> 
> 
> Testing
> -------
> 
> works on mac
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121216/8c48bca0/attachment.htm>


More information about the calligra-devel mailing list