Reviewboard stripping the git header of patches. (Was: Re: Review Request: Move ElapsedTime class to a private header that wont be installed)

[Philip Van Hoof]

Hi guys,

What I don't really like about KDE's reviewboard is that git adds a
header to diffs when using git format-patch. And when the diff gets
applied by a reviewer to Calligra, then because this header is stripped
git doesn't always recognize the patch having been applied with the
commit in my own git clone. And then I have to fix a huge conflict
afterward.

Can KDE's reviewboard be fixed not to strip that header and Calligra
maintainers use git am instead of patch to apply patches?

Kind regards,

Philip

On Fri, 2012-12-14 at 13:39 +0000, Philip Hoof wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107717/ 
> 
> Review request for Calligra.
> By Philip Hoof.
> Description 
> From 6df02b31d66934ac57a4bce123bab8fcc0dbdf82 Mon Sep 17 00:00:00 2001
> From: Philip Van Hoof <philip at codeminded.be>
> Date: Fri, 14 Dec 2012 14:34:49 +0100
> Subject: [PATCH] Move ElapsedTime class to a private header that wont be
>  installed
> 
> This also fixes a old-style-cast problem in the class's destructor
> Diffs 
>       * sheets/ElapsedTime_p.h (PRE-CREATION)
>       * sheets/Global.h (1759095)
>       * sheets/RecalcManager.cpp (c5674f2)
>       * sheets/part/CanvasBase.cpp (f973f40)
>       * sheets/part/Headers.cpp (f29408f)
>       * sheets/part/View.cpp (6a12d45)
>       * sheets/DocBase.cpp (d67c66d)
>       * sheets/DependencyManager.cpp (60e82e8)
> 
> View Diff
> 
> 
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel

-- 


Philip Van Hoof
Software developer
Codeminded BVBA - http://codeminded.be
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Move-ElapsedTime-class-to-a-private-header-that-wont.patch
Type: text/x-patch
Size: 7882 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121214/1a18be63/attachment.bin>