Review Request: [GCI] Adding d-pointers to kexi/formeditor

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107647/#review23356
-----------------------------------------------------------



kexi/formeditor/container.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17970>

    missing ~Container() and missing 'delete d'



kexi/formeditor/container.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17971>

    move { to a new line



kexi/formeditor/container.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17972>

    move { to a new line



kexi/formeditor/factories/containerfactory.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17992>

    change such lines to setPropertyDescription(....); fix that also in kexi/plugins/forms/



kexi/formeditor/factories/containerfactory.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17993>

    change such lines to setValueDescription(....); fix that also in kexi/plugins/forms/



kexi/formeditor/libactionwidget.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17973>

    missing 'delete d'



kexi/formeditor/objecttree.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17974>

    missing 'delete d'



kexi/formeditor/resizehandle.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17975>

    missing 'delete d'



kexi/formeditor/richtextdialog.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17976>

    missing 'delete d'



kexi/formeditor/tabstopdialog.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17977>

    missing 'delete d'



kexi/formeditor/widgetfactory.h
<http://git.reviewboard.kde.org/r/107647/#comment17991>

    change to propertyDescription(const char *name) const



kexi/formeditor/widgetfactory.h
<http://git.reviewboard.kde.org/r/107647/#comment17990>

    change to valueDescription(const char *name) const



kexi/formeditor/widgetfactory.h
<http://git.reviewboard.kde.org/r/107647/#comment17978>

    please remove getClassesByName()
    and add (PROTECTED) WidgetInfo* widgetInfoForClassName(const char* classname)



kexi/formeditor/widgetfactory.h
<http://git.reviewboard.kde.org/r/107647/#comment17981>

    please rename to (PROTECTED) 
    const QSet<QByteArray>* hiddenClases() const
    



kexi/formeditor/widgetfactory.h
<http://git.reviewboard.kde.org/r/107647/#comment17983>

    make PROTECTED, rename to library()



kexi/formeditor/widgetfactory.h
<http://git.reviewboard.kde.org/r/107647/#comment17985>

    make PROTECTED, change to advancedPropertiesVisible() const



kexi/formeditor/widgetfactory.h
<http://git.reviewboard.kde.org/r/107647/#comment17987>

    remove this, causes grave errors because we're returning here by value here;
    
    instead add:
     	
    /*! Sets the i18n'ed description of a property, which will be shown in PropertyEditor. */
    void setPropertyDescription(const char *property, const QString &description);



kexi/formeditor/widgetfactory.h
<http://git.reviewboard.kde.org/r/107647/#comment17988>

    remove this, causes grave errors because we're returning here by value here
    
    instead add:
     	
    /*! Sets the i18n'ed description of a property value, which will be shown in PropertyEditor. */
    void setValueDescription(const char *valueName, const QString &description);



kexi/formeditor/widgetfactory.h
<http://git.reviewboard.kde.org/r/107647/#comment17989>

    remove



kexi/formeditor/widgetfactory.h
<http://git.reviewboard.kde.org/r/107647/#comment17982>

    remove



kexi/formeditor/widgetfactory.h
<http://git.reviewboard.kde.org/r/107647/#comment17984>

    make PROTECTED



kexi/formeditor/widgetfactory.h
<http://git.reviewboard.kde.org/r/107647/#comment17986>

    make PROTECTED, change to setAdvancedPropertiesVisible(bool set)



kexi/formeditor/widgetfactory.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17980>

    missing 'delete hiddenClasses'



kexi/formeditor/widgetlibrary.cpp
<http://git.reviewboard.kde.org/r/107647/#comment17979>

    replace with 
    parentFactory->widgetInfoForClassName(w->inheritedClassName())


- Jarosław Staniek


On Dec. 12, 2012, 10:03 a.m., Andrey Inishev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107647/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 10:03 a.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Patch adding d-pointers to kexi/formeditor
> 
> 
> Diffs
> -----
> 
>   kexi/formeditor/FormWidget.h 87b3889 
>   kexi/formeditor/FormWidget.cpp bb83f98 
>   kexi/formeditor/WidgetTreeWidget.h 01d3727 
>   kexi/formeditor/WidgetTreeWidget.cpp a90aa01 
>   kexi/formeditor/connectiondialog.h 712ebe0 
>   kexi/formeditor/connectiondialog.cpp d89c46c 
>   kexi/formeditor/container.h 696361e 
>   kexi/formeditor/container.cpp 26d2f78 
>   kexi/formeditor/events.h ea498c5 
>   kexi/formeditor/events.cpp 04c5394 
>   kexi/formeditor/factories/containerfactory.cpp 95f155f 
>   kexi/formeditor/factories/stdwidgetfactory.cpp b010745 
>   kexi/formeditor/form.cpp 7f884ff 
>   kexi/formeditor/formIO.cpp ee11860 
>   kexi/formeditor/kexiformeventhandler.h 4482ba3 
>   kexi/formeditor/kexiformeventhandler.cpp 97face3 
>   kexi/formeditor/libactionwidget.h 63b120e 
>   kexi/formeditor/libactionwidget.cpp bc5d2bf 
>   kexi/formeditor/objecttree.h a37c220 
>   kexi/formeditor/objecttree.cpp 4544781 
>   kexi/formeditor/resizehandle.h c2b5116 
>   kexi/formeditor/resizehandle.cpp 4d70b0f 
>   kexi/formeditor/richtextdialog.h 5b8fc73 
>   kexi/formeditor/richtextdialog.cpp 3aa27f7 
>   kexi/formeditor/tabstopdialog.h d725344 
>   kexi/formeditor/tabstopdialog.cpp f45e56a 
>   kexi/formeditor/widgetfactory.h 0dd8c46 
>   kexi/formeditor/widgetfactory.cpp 145d513 
>   kexi/formeditor/widgetlibrary.h 81006cf 
>   kexi/formeditor/widgetlibrary.cpp 4e3a941 
>   kexi/formeditor/widgetwithsubpropertiesinterface.h 9b51b52 
>   kexi/formeditor/widgetwithsubpropertiesinterface.cpp 7d80f82 
> 
> Diff: http://git.reviewboard.kde.org/r/107647/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey Inishev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121212/5c946428/attachment.htm>