Review Request: honor the suffix of the filename the user selected when exporting from odt to (x)html

Friedrich W. H. Kossebau kossebau at kde.org
Wed Dec 12 14:49:50 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107676/
-----------------------------------------------------------

Review request for Calligra, Inge Wallin and mojtaba shahi.


Description
-------

Currently the suffix is ignored and always .xhtml is used. While .xhtml might be the correct suffix for the content which is currently created by the export filter, still the user should be more right. If she/he wants something else, it should be delivered.

Attached patch changes the behaviour to use the suffix of the filename passed to the export filter for all files that are generated.
It's not the optimal patch. I had no real idea how to inject the user-choosen suffix just for the case of one file, as with (x)html export. Perhaps you have a better idea.
But at least it works :)

Okay to commit to 2.6 and port to master?


Diffs
-----

  filters/words/epub/FileCollector.h e705026 
  filters/words/epub/FileCollector.cpp b25bfa6 
  filters/words/epub/OdtHtmlConverter.cpp ac8dcc4 
  filters/words/epub/exporthtml.cpp d657490 

Diff: http://git.reviewboard.kde.org/r/107676/diff/


Testing
-------

export as html to a file with custom suffix uses that suffix
export to epub uses xhtml as before internally


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121212/cd1d4eb1/attachment.htm>


More information about the calligra-devel mailing list