Review Request: [GCI] Adding d-pointers to kexi/main

Jarosław Staniek staniek at kde.org
Wed Dec 12 08:36:30 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107648/#review23343
-----------------------------------------------------------


Thanks for the effort but please revert unused code removal from kexi/main/KexiMainWindow.cpp, these changes are not related and are too deep, we need these for some time.

- Jarosław Staniek


On Dec. 12, 2012, 7:49 a.m., Andrey Inishev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107648/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 7:49 a.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Patch adding d-pointers to kexi/main
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.cpp ccc885a 
>   kexi/main/startup/KexiStartup.h 9694f53 
>   kexi/main/startup/KexiStartup.cpp 23d2a56 
>   kexi/main/startup/KexiTemplatesModel.h 995930e 
>   kexi/main/startup/KexiTemplatesModel.cpp 80d5bf5 
> 
> Diff: http://git.reviewboard.kde.org/r/107648/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey Inishev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121212/8fdd2795/attachment.htm>


More information about the calligra-devel mailing list